Extract transports into Bedrock.Framework.Transports package #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wl#172) Introduce a lightweight Bedrock.Framework.Transports package so consumers can use socket, memory, named pipe, and connection pooling transports without pulling in the full Bedrock.Framework and its Kestrel dependency. Transports moved: - Sockets (SocketConnectionFactory, SocketConnection, etc.) from Bedrock.Framework - Memory (MemoryTransport, MemoryEndPoint) from Bedrock.Framework - Named Pipes from Bedrock.Framework.Experimental - Connection Pooling from Bedrock.Framework.Experimental (HttpEndPoint and HttpConnectionKind remain in Experimental) Dependency changes: - New project uses PackageReference to Microsoft.AspNetCore.Connections.Abstractions instead of FrameworkReference to Microsoft.AspNetCore.App - Bedrock.Framework now has a ProjectReference to Bedrock.Framework.Transports Bug fixes found during extraction: - MemoryEndPoint: add missing Equals override to match GetHashCode - SocketConnectionFactory: forward CancellationToken to Socket.ConnectAsync - IMaxConnectionFeature: change from internal to public so HttpEndPoint in Experimental can implement it across assembly boundaries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172
While moving the files 🤖 Copilot found and fixed a bug in MemoryEndPoint (GetHashCode without Equals).
Introduce a lightweight Bedrock.Framework.Transports package so consumers can use socket, memory, named pipe, and connection pooling transports without pulling in the full Bedrock.Framework and its Kestrel dependency.
Transports moved:
Dependency changes:
Bug fixes found during extraction: