Skip to content

Firefox Port and Version Increase from 0.4.6 --> 0.4.7#29

Open
that-gai-gai wants to merge 3 commits into
david-r-edgar:masterfrom
that-gai-gai:master
Open

Firefox Port and Version Increase from 0.4.6 --> 0.4.7#29
that-gai-gai wants to merge 3 commits into
david-r-edgar:masterfrom
that-gai-gai:master

Conversation

@that-gai-gai

Copy link
Copy Markdown

I ported over the extension to firefox and it is working fine. I had to change some things in tippy.min.js. My suggestion is to test on chrome on your side to ensure functionality remains unharmed.

A quick port to Firefox. Updated Manifest and Readme.
Accidentally changed from HTML to Text insert
Ensured parity between version increase in both the manifest.json and about.html files
@david-r-edgar

david-r-edgar commented Jul 3, 2021

Copy link
Copy Markdown
Owner

Thanks for this! It looks like you've modified the minified tippy library. Is this just a new version (if so, which?), or did you make other changes to it? Do you have a link to the original source?

I understand that submission to the mozilla add-ons store requires the actual unminified source to be available for review, with correct version numbers and links (https://extensionworkshop.com/documentation/publish/third-party-library-usage/), so I think there are a few further changes necessary (or at least details to be researched) for a number of libraries before I can actually submit this for signing.

@that-gai-gai

Copy link
Copy Markdown
Author

I am just now seeing this...I'll double check about the versioning and get back with you this weekend!

@rootkea

rootkea commented Jun 21, 2026

Copy link
Copy Markdown

@that-gai-gai @david-r-edgar, can we please get this going?
Related: #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants