WIP: v0.15.0 #598
Merged
WIP: v0.15.0 #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because an object can be found by multiple paths, vacuum now stores all possible paths to an object and then uses that for ignoring. #526
provides more accurate lookups and solved the inconsistent deterministic output.
More accurate now.
Checks if path items have used a reference or not. Used quite a lot out there in the wild, however they are invalid.
I made a mistake, but it’s still good practice.
When using an ignore list, we need to build a deep graph because the model works async and some objects may be located at a different point, so the deep graph will track all paths to an object and make them available to the ignore list.
also removed string buf check, it’s flaky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds updated lookup code to core functions. Uses a new
BuildDeepGraphbuild in the doctor when using ignore files.Adds new rule
path-item-refsFixes #502 by offering a new
NodeLookupTimeoutoption on ruleset execution.Fixes #592
Fixes #583 correctly