feat: Adds owasp rules to vacuum #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Ricagraca
changed the title
daveshanley
reviewed
Jun 4, 2023
Thanks to @markdespain for the tip Signed-off-by: Dave Shanley <[email protected]>
Pattern output is now clear when using paths, before it was not accurate. Signed-off-by: Dave Shanley <[email protected]>
No more panic when hitting up/down within emoty lists. Signed-off-by: Dave Shanley <[email protected]>
Added a test to validate. Signed-off-by: Dave Shanley <[email protected]>
Lots of commits, and work from contributors, and me changing machines and Goland having random fun.. it’s time to clean house again. Signed-off-by: Dave Shanley <[email protected]>
Signed-off-by: Dave Shanley <[email protected]>
Signed-off-by: Dave Shanley <[email protected]>
Signed-off-by: Dave Shanley <[email protected]>
When vacuum was reading in the function options for a rule, it was not constructing the schema from the options correctlty. This bug may exist in other functions, but it’s been fixed here. Signed-off-by: Dave Shanley <[email protected]>
…sy function whenever the node has content (it not empty)
…at duplicate errors will appear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves to extend vacuum with the OWASP rules that already exist for spectral:
https://github.com/stoplightio/spectral-owasp-ruleset/blob/main/src/ruleset.ts
and use the tests that they provide to guarantee quality
https://github.com/stoplightio/spectral-owasp-ruleset/blob/main/__tests__/