moving older emulators to end of list #841
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have gnome-terminal installed, but it won't get run by this script because it finds uxterm and xterm first. Moving those to the end fixes this, and should fix the problem for other users--assuming xterm is installed by default in most distros.
|
there is a reason behind the order of terminal emulators. The ones that come with big DEs are explicitly listed after those that don't come automatically. That's done because chances are much higher you installed "termite" or similar explicitly in order to use it. |
|
That's what I thought was happening--so wouldn't it make sense for xterm to
be at the end, since nearly every distro includes it by default? Or at
least after gnome-terminal, which is more specific. The order I changed it
to is the only way I could get it to load gnome-terminal instead of
xterm/uxterm.
…On Mon, Jul 30, 2018, 6:57 PM Rasmus Steinke ***@***.***> wrote:
there is a reason behind the order of terminal emulators. The ones that
come with big DEs are explicitly listed after those that don't come
automatically. The reasoning is that chances are much higher you installed
"termite" or similar explicitly in order to use it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#841 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABW7hvhjwZeJZDhJUhX2706CbH8yAE1dks5uL7mUgaJpZM4Vkn05>
.
|
sc0ttj
reviewed
Oct 5, 2019
| @@ -9,7 +9,7 @@ | |||
| # We welcome patches that add distribution-specific mechanisms to find the | |||
| # preferred terminal emulator. On Debian, there is the x-terminal-emulator | |||
| # symlink for example. | |||
| for terminal in $TERMINAL x-terminal-emulator termite urxvt rxvt st terminator terminology qterminal Eterm aterm uxterm xterm gnome-terminal roxterm xfce4-terminal mate-terminal lxterminal konsole alacritty; do | |||
| for terminal in $TERMINAL x-terminal-emulator termite urxvt rxvt st terminator terminology qterminal Eterm aterm gnome-terminal roxterm xfce4-terminal mate-terminal lxterminal konsole alacritty uxterm xterm; do | |||
There was a problem hiding this comment.
Also misses the excellent mlterm off the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have gnome-terminal installed, but it won't get run by this script because it finds uxterm and xterm first. Moving those to the end fixes this, and should fix the problem for other users--assuming xterm is installed by default in most distros.