Follow up #2000 #2015
Merged
Follow up #2000 #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
both switching with left shift and ctrl-u seems to work for me. Thanks! (odd/shame we need a 5ms timeout.. ) |
Yeah. I suppose it's related to some packet coalescing issue. Fortunately, we only need to delay for the release of modifiers, which should have minimal impact. |
|
yeah, it works for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #2000 (comment)
It seems we can work around the limitation of XCB XIM by introducing a short sleep before forwarding the release event of modifier keys. This change should enable all modifier keys to function correctly with the input method.
@DaveDavenport, could you please test this solution again? I believe it will also resolve the ctrl-u issue you experienced earlier.
@xsy420, could you please check if this fix works for you as well?