Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -transient-window mode #1988

Merged
merged 3 commits into from
Jun 9, 2024
Merged

Add -transient-window mode #1988

merged 3 commits into from
Jun 9, 2024

Conversation

pijulius
Copy link
Contributor

@pijulius pijulius commented Jun 9, 2024

Please follow these steps before submitting your PR:

  • [ X] This PR targets the next branch and not master
  • [ -] If your PR is a work in progress, include [WIP] in its title
  • [ X] Its commits' summaries are reasonably descriptive
  • [ X] You've described what this PR addresses below
  • [ -] You've included links to relevant issues, if any with #issue_num
  • [ -] You've deleted this template

Thank you for contributing to rofi! <3

This will add a new mode for the rofi window so when you run it with -transient-window

instead of
-normal-window

it will get the currently focused window and then use that as the parent window and set itself as transient of that window. It is useful so that when you use a keyboard shortcut to start rofi it will always popup on the window you are working on and so it doesn't make you refocus/move your head on large monitors :)

This will add a new mode for the rofi window so when you run it with
-transient-window

instead of
-normal-window

it will get the currently focused window and then use that as the parent window and set itself as transient of that window.  It is useful so that when you  use a keyboard shortcut to start rofi it will always popup on the window you are working on and so it doesn't make you refocus/move your head on large monitors :)
and added print_help_msg for this new -transient-window option.
@DaveDavenport
Copy link
Collaborator

Good idea!

Can you include it in the manpages? then can will merge it.

@pijulius
Copy link
Contributor Author

pijulius commented Jun 9, 2024

Thanks @DaveDavenport ! happy to see you like it too, not sure about the docs, this is what you had in mind?:
f621786

@DaveDavenport DaveDavenport merged commit 5133f50 into davatorium:next Jun 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants