Add border_width to window coordinates #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
window coors relative to border_width.
Normalize the geometry between reparenting and non- window managers.
ortango
changed the title
|
This changes current behavior for both reparenting and non-reparenting wm's. In both cases 100% x/y offsets and height/width of the window fills the area inside the border/decorations. so these changes are a little to much. i tested the following wm's : bspwm, dwm, i3 and everything is fine with -m -{2,4}. so, this patch also fixes -m -2 for other nonreparenting wm's aside from bspwm. |
* remove WM_ROOT_WINDOW_OFFSET * only translate reparent
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #1968, this patch is to account to border_width for window coordinates when displaying on the currently focused window (
-monitor -2).Rather then add border width to the window's height and width, we are moving the x, y offsets. 100% of the window would be everything but the border. I looked through xlib manual and icccm, but did not come across a defacto standard for this.