Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] xdg thumbnails fetching with fallback on mimetype icons #1939

Merged
merged 37 commits into from
Jun 21, 2024
Merged

[WIP] xdg thumbnails fetching with fallback on mimetype icons #1939

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
37353b7
implemented xdg thumbnails fetching with fallback on mimetype icons f…
Jan 28, 2024
a6271dc
included original license text
Jan 28, 2024
68272ce
added md5 header and source file
Jan 28, 2024
5b64132
implemented xdg compatible thumbnail's creation
Jan 30, 2024
423ee4e
added -preview-cmd string option to program settings
Feb 2, 2024
1b9eec5
support custom command to create images for entries with thumbnail://…
Feb 2, 2024
32a9ffa
fix custom thumbnailer command crash caused by null uri when entry is…
Feb 5, 2024
aa44499
check entry_name is not NULL or empty when generating thumbnails;
Feb 5, 2024
c573765
avoid using gstrvbuilder to build thumbnailer command args
Feb 6, 2024
50d8ed9
fixed static analyzer complain about always wrong condition
Feb 6, 2024
059f748
use g_spawn_check_exit_status to avoid bump to glib 2.70
Feb 6, 2024
e243304
Merge branch 'davatorium:next' into next
giomatfois62 Feb 11, 2024
e6e2f87
removed md5-c dependency and use glib checksum implementation
Feb 12, 2024
600563c
fixed meson build after md5-c library removal
Feb 13, 2024
9d8e0f3
support thumbnail generation in recursivebrowser mode
Feb 13, 2024
b57bc6d
restored check rofi_icon_fetcher_file_is_image
Feb 13, 2024
29a2b39
create thumbnail directories if not existing
Feb 13, 2024
8152a71
use g_malloc0, g_strdup and g_strdup_printf
Feb 13, 2024
c5e13e6
fixed formatting with clang-format
Feb 14, 2024
15e206d
don't wait for jobs in execution when finalizing the icon fetcher wor…
Feb 20, 2024
cfdcc09
destroy and rebuild the icon fetcher worker threadpool when the curre…
Feb 20, 2024
f7fe484
added query_started boolean member to IconFetcherEntry;
Feb 20, 2024
6c5b8be
force icon cache lookup even if the item has a valid icon_fetch_uid (…
Feb 20, 2024
3284837
search binaries in PATH when executing thumbnailer command
Feb 26, 2024
dcf7505
Merge branch 'davatorium:next' into next
giomatfois62 Mar 2, 2024
f5227cc
Merge branch 'next' into next
giomatfois62 Mar 3, 2024
4933d4b
Merge branch 'davatorium:next' into next
giomatfois62 Mar 8, 2024
b179ff0
mark icon query as not started in threadpool item free_func
Mar 9, 2024
58ff766
added listview page_changed_callback; rebuild icon fetcher threadpool…
Mar 9, 2024
97b25eb
[listview] Add missing code documentation param
DaveDavenport Mar 10, 2024
92a7aae
Merge branch 'davatorium:next' into next
giomatfois62 May 16, 2024
5d69c64
Create rofi-thumbnails.5.markdown
giomatfois62 May 16, 2024
46473d4
Updated documentation with apparmor issues and workaround
giomatfois62 May 25, 2024
0d0b476
Merge branch 'next' into next
DaveDavenport Jun 8, 2024
90c4ea8
Merge branch 'next' into next
giomatfois62 Jun 19, 2024
6acf5db
[Doc] Ship rofi-thumbnails.5
lbonn Jun 19, 2024
8a671cb
use a more compact thumbnailer example
giomatfois62 Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions config/config.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ Settings config = {

/** Whether to load and show icons */
.show_icons = FALSE,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small styling issue: there are trailing white spaces on empty lines in the whole diff. We can remove them before merging if possible.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend running clang-format with default settings, that should in general be the style used.

/** Custom command to generate preview icons */
.preview_cmd = NULL,

/** Terminal to use. (for ssh and open in terminal) */
.terminal_emulator = "rofi-sensible-terminal",
Expand Down
3 changes: 3 additions & 0 deletions include/settings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ typedef struct {

/** Whether to load and show icons */
gboolean show_icons;

/** Custom command to generate preview icons */
char *preview_cmd;

/** Terminal to use */
char *terminal_emulator;
Expand Down
4 changes: 4 additions & 0 deletions source/modes/filebrowser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,6 +614,10 @@ static cairo_surface_t *_get_icon(const Mode *sw, unsigned int selected_line,
}
if (rofi_icon_fetcher_file_is_image(dr->path)) {
dr->icon_fetch_uid = rofi_icon_fetcher_query(dr->path, height);
} else if (dr->type == RFILE) {
gchar* _path = g_strconcat("thumbnail://", dr->path, NULL);
dr->icon_fetch_uid = rofi_icon_fetcher_query(_path, height);
g_free(_path);
} else {
dr->icon_fetch_uid = rofi_icon_fetcher_query(icon_name[dr->type], height);
}
Expand Down
10 changes: 5 additions & 5 deletions source/modes/recursivebrowser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,12 +447,12 @@ static cairo_surface_t *_get_icon(const Mode *sw, unsigned int selected_line,
FBFile *dr = &(pd->array[selected_line]);
if (dr->icon_fetch_uid > 0 && dr->icon_fetch_size == height) {
return rofi_icon_fetcher_get(dr->icon_fetch_uid);
}
if (rofi_icon_fetcher_file_is_image(dr->path)) {
lbonn marked this conversation as resolved.
Show resolved Hide resolved
dr->icon_fetch_uid = rofi_icon_fetcher_query(dr->path, height);
}else if (dr->type == RFILE) {
gchar* _path = g_strconcat("thumbnail://", dr->path, NULL);
dr->icon_fetch_uid = rofi_icon_fetcher_query(_path, height);
g_free(_path);
} else {
dr->icon_fetch_uid =
rofi_icon_fetcher_query(rb_icon_name[dr->type], height);
dr->icon_fetch_uid = rofi_icon_fetcher_query(rb_icon_name[dr->type], height);
}
dr->icon_fetch_size = height;
return rofi_icon_fetcher_get(dr->icon_fetch_uid);
Expand Down
Loading
Loading