refactor: consolidate configuration into centralized config package#245
Merged
Conversation
Replace scattered viper reads in galactic-router with a centralized RouterConfig in internal/config, matching the existing CNIConfig pattern. Rename CNIViper to CNIConfig with field-based access and split the monolithic config.go into separate files per component for clearer ownership. - Rename CNIViper to CNIConfig with exported fields and Resolve() method - Add RouterConfig with NewRouterConfig(), BindFlags(), and Validate() - Split internal/config into config.go, cni.go, and router.go - Remove inline newViper(), bindFlags(), and validateConfig() from root.go - Update root.go to accept *RouterConfig instead of *viper.Viper - Rewrite config, CNI, and router test suites for the new APIs - Update router configuration docs to reference the config package
|
@privateip flip plugin auto-update on to fix yer linewrap |
ecv
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace scattered viper reads in galactic-router with a centralized
RouterConfig in internal/config, matching the existing CNIConfig pattern.
Rename CNIViper to CNIConfig with field-based access and split the monolithic
config.go into separate files per component for clearer ownership.