Skip to content

fix(cni): forward DEL to host-device delegated plugin #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
privateip merged 1 commit into from
Jul 17, 2026
Merged

fix(cni): forward DEL to host-device delegated plugin #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/cni/ops_del.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,13 @@ func cmdDel(args *skel.CmdArgs) error {
}
}

// Forward DEL to host-device delegated plugin (CNI spec §4).
// host-device DEL is idempotent — missing devices are not errors.
// Only applies to veth mode; tap mode has no host-device delegation.
if pluginConf.InterfaceType == interfaceTypeVeth {
_ = hostDevice("DEL", args, pluginConf)
}

// Shared resources (VRF, veth/tap, routes, SRv6 ingress, BGPAdvertisement,
// BGPVRFInstance) are keyed by (vpc, vpcAttachment) and may still be in use
// by another pod. Deleting them here races with cmdAdd during pod restarts —
Expand Down