Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates and tests #23

Merged
merged 18 commits into from
Nov 10, 2023
Merged

updates and tests #23

merged 18 commits into from
Nov 10, 2023

Conversation

njayp
Copy link
Contributor

@njayp njayp commented Oct 24, 2023

  • helm install/uninstall action
  • general fixes
  • test workflow

@njayp njayp marked this pull request as draft October 24, 2023 23:50
@njayp njayp closed this Oct 24, 2023
@njayp njayp reopened this Oct 24, 2023
@njayp
updates and tests
a03f0f5 
Signed-off-by: njayp <[email protected]>
@njayp njayp force-pushed the njayp/updates-and-tests branch 5 times, most recently from 4a36eb6 to 43efc1f Compare October 27, 2023 16:35
@knlambert knlambert linked an issue Oct 30, 2023 that may be closed by this pull request
Telepresence Actions -- Updates and Testing #22
Closed
@njayp
deps
f6ef86b 
Signed-off-by: njayp <[email protected]>
@knlambert
Copy link

Any news on this one ? :D

@njayp
Copy link
Contributor Author

njayp commented Nov 1, 2023

Any news on this one ? :D

I got it to build. Now i just need to get my tests to pass. I have an odd issue where core isn't propagating my secret

@njayp
upgrade deps
e7f7e11 
Signed-off-by: njayp <[email protected]>
@njayp njayp force-pushed the njayp/updates-and-tests branch 3 times, most recently from 4160704 to 2bf184f Compare November 3, 2023 07:17
@njayp njayp force-pushed the njayp/updates-and-tests branch 3 times, most recently from c8cec4b to 2ad55c1 Compare November 3, 2023 08:58
@njayp
wait for demo app
727a71c 
Signed-off-by: njayp <[email protected]>
@njayp njayp marked this pull request as ready for review November 6, 2023 00:13
@njayp njayp requested a review from shepz November 6, 2023 00:13
shepz
shepz reviewed Nov 6, 2023
View reviewed changes
Copy link

@shepz shepz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the README is up-to-late with those changes ?

.github/workflows/integration-tests.yaml
version: "v1.25.3"
id: kubectl
- name: Provision Kubeception cluster
uses: datawire/infra-actions/[email protected]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason not to use the last version ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, i just copied from our integration tests w/o checking

.github/workflows/integration-tests.yaml
- name: Test Intercept with Curl
shell: bash
run: |
sleep 3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do something better than a sleep ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think so. we could have a retry, but thats basically the same thing 🤷

@njayp njayp merged commit 0faa1e7 into main Nov 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shepz shepz shepz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telepresence Actions -- Updates and Testing
3 participants
@njayp @knlambert @shepz