Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://datawire.slack.com/archives/C01PUJXR6CT/p1738607830906789
Summary
We already had code in place for rebundling in
getHttpOperationsFromSpec
function, so I made an effective use of that (on a side note - this code was pretty much no-op as things stood, the only thing it did was rewriting the top-level refs)I considered using deference with
circular="ignore"
, but the results were rather similar as far as the negotiated content is concerned (arguably the output prior to this change was slightly better for circular structures, as we kept at least a single copy and then left a hole). That said, I might still change it to that, as it's likely to be faster.I tried not to touch json-schema-ref-parser (to avoid needing to fork it), but I'll have a look at some point.
Checklist
Screenshots