Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): introduce --watch and --watch-strategy flags #13

Merged
merged 3 commits into from
Jan 6, 2025
Merged

feat(cli): introduce --watch and --watch-strategy flags #13

merged 3 commits into from
Jan 6, 2025

Conversation

P0lip
Copy link
Member

@P0lip P0lip commented Jan 6, 2025

Summary

This makes fs watching optional and introduces different modes, with polling being the default.

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

@P0lip P0lip self-assigned this Jan 6, 2025
@P0lip P0lip requested a review from dotslashderek January 6, 2025 20:35
@P0lip P0lip marked this pull request as ready for review January 6, 2025 20:35
@P0lip P0lip enabled auto-merge (rebase) January 6, 2025 21:17
@P0lip P0lip merged commit eed73b4 into main Jan 6, 2025
3 checks passed
@P0lip P0lip deleted the jrozek/dev/fs-watchers branch January 6, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotslashderek dotslashderek dotslashderek approved these changes

Assignees

@P0lip P0lip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@P0lip @dotslashderek