Skip to content

Commit

Permalink
Legacy RLS: fix Envoy build to pickup proper proto file from service/…
Browse files Browse the repository at this point in the history
…ratelimit/v1.

This commit fixes the build failure when Datawire patch for legacy
ratelimit service is applied.

With this change Envoy would continue making RateLimitService method
call to pb.lyft.ratelimit path. So clients who have their own
RateLimitService based on lyft rls service would be able to upgrade to
Envoy 1.13 without any issue.

Note that I tried to use tools/proto_format for generating v1 things
under generated_api_shadow but it seems it's not suited for downgrading
rather it's useful for migration from v2 to v3 and probably to v4 for
future. So I manually place the legacy files under generated_api_shadow.
  • Loading branch information
alphashr committed Apr 28, 2020
1 parent 53c818a commit 0aca7d2
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 0 deletions.
10 changes: 10 additions & 0 deletions generated_api_shadow/envoy/service/ratelimit/v1/BUILD

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions generated_api_shadow/envoy/service/ratelimit/v1/rls.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0aca7d2

Please sign in to comment.