Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 8.0.1 #190

Merged
merged 12 commits into from
Feb 21, 2024
Merged

Release 8.0.1 #190

merged 12 commits into from
Feb 21, 2024

Commits on Jan 24, 2024

  1. Configuration menu
    Copy the full SHA
    f4c4dc5 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. chore(deps): bump cachetools from 5.3.1 to 5.3.2 (#147)

    Bumps [cachetools](https://github.com/tkem/cachetools) from 5.3.1 to 5.3.2.
    - [Changelog](https://github.com/tkem/cachetools/blob/master/CHANGELOG.rst)
    - [Commits](tkem/cachetools@v5.3.1...v5.3.2)
    
    ---
    updated-dependencies:
    - dependency-name: cachetools
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    953c74b View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Configuration menu
    Copy the full SHA
    72c8b8b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1857073 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Configuration menu
    Copy the full SHA
    92ec4fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1d9b01d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0950d3e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    426854c View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    7a6266e View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Configuration menu
    Copy the full SHA
    6f315ba View commit details
    Browse the repository at this point in the history
  2. fix: vis is rendered with an invalid config (#172)

    ### Developer Checklist (Definition of Done)
    
    **Issue**
    
    - [ ] All acceptance criteria from the issue are met
    - [x] Tested in latest Chrome/Firefox
    
    **UI/UX/Vis**
    
    - [ ] Requires UI/UX/Vis review
      - [ ] Reviewer(s) are notified (_tag assignees_)
      - [ ] Review has occurred (_link to notes_)
      - [ ] Feedback is included in this PR
      - [ ] Reviewer(s) approve of concept and design
    
    **Code**
    
    - [x] Branch is up-to-date with the branch to be merged with, i.e.,
    develop
    - [x] Code is cleaned up and formatted
    - [ ] Unit tests are written (frontend/backend if applicable)
    - [ ] Integration tests are written (if applicable)
    
    **PR**
    
    - [x] Descriptive title for this pull request is provided (will be used
    for release notes later)
    - [x] Reviewer and assignees are defined
    - [x] Add type label (e.g., *bug*, *feature*) to this pull request
    - [x] Add release label (e.g., `release: minor`) to this PR following
    [semver](https://semver.org/)
    - [x] The PR is connected to the corresponding issue (via `Closes #...`)
    - [x] [Summary of changes](#summary-of-changes) is written
    
    
    ### Summary of changes
    We have the issue that we are providing vis an externalConfig that does
    not include all possible defaults
    ```typescript
      const config = {
        type: 'Heatmap plot',
        catColumnsSelected: [
          { id: 'Column 1', name: 'Column 1' },
          { id: 'Column 2', name: 'Column 2' },
        ],
      };
    ```
    This is the different values the vis was being rendered with (causes
    errors) when inputing the above config
    ```
    MainApp.tsx: Parent {type: 'Heatmap plot', catColumnsSelected: Array(2)}
    MainApp.tsx:40 Parent null
    MainApp.tsx:40 Parent {type: 'Heatmap plot', catColumnsSelected: Array(2), color: {…}}
    MainApp.tsx:40 Parent {type: 'Heatmap plot', color: {…}, catColumnsSelected: Array(2), numColorScaleType: 'Sequential', xSortedBy: 'CAT_ASC', …}
    ```
    
    And this with this fix
    
    ```
    MainApp.tsx: Parent {type: 'Heatmap plot', catColumnsSelected: Array(2)}
    MainApp.tsx:40 Parent {type: 'Heatmap plot', color: {…}, catColumnsSelected: Array(2), numColorScaleType: 'Sequential', xSortedBy: 'CAT_ASC', …}
    ```
    
    We could improve the logic and readabilty of this section of code when
    we switch completely to mantine 7 to use
    https://mantine.dev/hooks/use-uncontrolled/
    
    ### Screenshots
    
    before
    
    ![gr-original](https://github.com/datavisyn/visyn_core/assets/51322092/ea036357-6411-4592-aaf2-a1b469ce2d3e)
    after
    
    ![gr-new](https://github.com/datavisyn/visyn_core/assets/51322092/a9e2aac0-b55a-4395-a25b-7eb0e908fdd0)
    
    
    
    ### Additional notes for the reviewer(s)
    
    -  
    Thanks for creating this pull request 🤗
    puehringer committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    30da502 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Configuration menu
    Copy the full SHA
    fbbf9b7 View commit details
    Browse the repository at this point in the history