-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: vis is rendered with an invalid config #172
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
72c8b8b
fix: merge visConfig defaults before painting
oltionchampari 1857073
fix: null category in heatmap
oltionchampari 92ec4fb
fix: heatmap invalid settings
oltionchampari 1d9b01d
fix: try a simpler solution
oltionchampari 0950d3e
Merge branch 'develop' into och/vis-initialization
oltionchampari 426854c
fix: use style instead of sx
oltionchampari 7a6266e
refactor: use useUncontrolled hook in EagerVis
oltionchampari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,7 +26,7 @@ export function HeatmapText({ | |
isImmediate: boolean; | ||
}) { | ||
const labelSpacing = useMemo(() => { | ||
const maxLabelLength = d3.max(yScale.domain().map((m) => m.length)); | ||
const maxLabelLength = d3.max(yScale.domain().map((m) => m?.length)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accounts for null categories. They are still shown in the visualization but at least the application does not crash. |
||
|
||
return maxLabelLength > 5 ? 35 : maxLabelLength * 7; | ||
}, [yScale]); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Invalid settings message is shown shortly while the state is
idle
. This change fixes that. The other visualizations account for theidle
state already.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this issue and the mention.