Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: automate releases #74

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

dvviktordelev
Copy link
Contributor

This is based on previous PR
it adds dynamic creation of release notes (= list of closed PRs since last release)

closes https://github.com/datavisyn/infrastructure-k8s/issues/241

dv-hossam-radwan and others added 30 commits April 4, 2024 14:35
Fix lint in release-source.yml

Fix lint in release-source.yml

Fix lint in release-source.yml

Fix version validation error in release-source.yml

Fix lint

Fix lint in release-source.yml

Remove empty line in release-source workflow

Update release_version input to be required in release-source.yml

Update release-source workflow

Update release-source workflow inputs

Update release-source workflow to use workflow_dispatch event

Update release-source workflow

Fix file_release_version extraction in release-source.yml

Add version increment logic

Fix version comparison bug

Fix version validation in release-source.yml

extend  version comparison logic in release-source.yml

Fix version comparison bug in release-source.yml

Fix version comparison bug in release-source.yml

Fix version comparison bug in release-source.yml

Fix version comparison bug in release-source.yml

Fix version comparison bug in release-source.yml

Fix version comparison bug in release-source.yml

Fix version comparison bug in release-source.yml

Fix version comparison bug in release-source.yml
Fix typo

fix helm dep

fix helm dep

fix helm build

fix helm build

add chartmuseum token

add chartmuseum

Add CHARTMUSEUM_TOKEN to environment variables

chore: Update Chart.yaml with release version for marvinjs

fix typo

fix typo

fix lint
.github/workflows/release-source.yml Outdated Show resolved Hide resolved
.github/workflows/release-source.yml Show resolved Hide resolved
Copy link
Contributor

@dvvanessastoiber dvvanessastoiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for the implementation!

Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are testing this action currently in reprovisyn and will post the errors one by one until it succeeds. 😉

git commit -m "Update package.json version to $RELEASE_VERSION"
git push origin release-"$RELEASE_VERSION"
- name: Add Helm repository
run: helm repo add datavisyn --username admin --password ${{ env.CHARTMUSEUM_TOKEN }} https://chartmuseum.app.datavisyn.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this action in reprovisyn fails with the following error:

Error: "helm repo add" requires 2 arguments
Usage:  helm repo add [NAME] [URL] [flags]
Error: Process completed with exit code 1.

https://github.com/datavisyn/reprovisyn/actions/runs/9765252351/job/26955506135

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix committed

@dvvanessastoiber
Copy link
Contributor

@dvviktordelev We tested the branch with marketplace360 and it worked very well 🎉 thank you!

When you have time, please continue with automating the remaining steps:

  1. Once the PR is merged, copy the release notes and create a Github Release: https://github.com/datavisyn/<app>/releases/new (create new tag with vX.X.X, choose main as target, use the release notes for the description and set vX.X.X as release title)
  2. Merge main into develop
  3. Prepare next dev version by increasing the released version by one patch version in the package.json and add -SNAPSHOT suffix (e.g. 8.0.0 --> 8.0.1-SNAPSHOT or 5.1.3 --> 5.1.4-SNAPSHOT)

Please let me know if you need any further details. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants