Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for self-hosted runner #64

Merged
merged 28 commits into from
May 8, 2024
Merged

changes for self-hosted runner #64

merged 28 commits into from
May 8, 2024

Conversation

dvviktordelev
Copy link
Contributor

No description provided.

@dvviktordelev dvviktordelev self-assigned this May 8, 2024
@@ -160,7 +166,6 @@ jobs:
with:
python_version: ${{ secrets.PYTHON_VERSION || env.PYTHON_VERSION }}
github_ro_token: ${{ github.event.repository.private == true && secrets.DATAVISYN_BOT_REPO_TOKEN || github.token }}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary line change

yarn start dev_server_only=true
make start
wait-on: "http://localhost:8080, http://localhost:9000/health"
env: ${{ secrets.CYPRESS_ENV }}
spec: ${{ inputs.cypress_spec_param }}
#env: ${{ secrets.CYPRESS_ENV }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these commented out lines be removed?

@puehringer puehringer merged commit 0b49a22 into main May 8, 2024
1 check passed
@puehringer puehringer deleted the vdelev_selfhosted branch May 8, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants