Skip to content

Commit

Permalink
remove "disable_cache" input
Browse files Browse the repository at this point in the history
  • Loading branch information
dvviktordelev committed May 8, 2024
1 parent 866ad21 commit c98b079
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 17 deletions.
7 changes: 1 addition & 6 deletions .github/actions/build-node/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ inputs:
run_webpack:
default: false
required: false
disable_cache:
description: "Set to true to disable caching"
default: false
required: false

runs:
using: "composite"
Expand Down Expand Up @@ -67,7 +63,6 @@ runs:
name: node-yarn-lock
# Enable yarn download cache, @see https://github.com/actions/cache/tree/main/save#always-save-cache and https://github.com/actions/setup-node/issues/325
- name: Restore yarn cache
if: inputs.disable_cache == 'false'
uses: actions/cache/restore@v3
with:
# This path is the global yarn cache, because for some reason the local .yarn/cache is not used. Maybe we need to set the cacheFolder, enableGlobalCache, ... options differently? @see https://yarnpkg.com/configuration/yarnrc#cacheFolder
Expand All @@ -80,7 +75,7 @@ runs:
run: yarn install --no-immutable --inline-builds
shell: bash
- name: Save yarn cache
if: inputs.disable_cache == 'false' && steps.install.outcome == 'success'
if: steps.install.outcome == 'success'
uses: actions/cache/save@v3
with:
# This path is the global yarn cache, because for some reason the local .yarn/cache is not used. Maybe we need to set the cacheFolder, enableGlobalCache, ... options differently? @see https://yarnpkg.com/configuration/yarnrc#cacheFolder
Expand Down
11 changes: 0 additions & 11 deletions .github/workflows/build-node-python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,6 @@ on:
required: false
description: Unique id per workflow run. Must be set to unique value if dispatched multiple times for a single workflow.
default: ""
#disable_cache:
# description: "Set to true to disable caching"
# required: false
# type: boolean
# default: false
chromatic_enable:
description: 'Enable Chromatic Tests'
required: false
Expand Down Expand Up @@ -141,7 +136,6 @@ jobs:
npm_registry: ${{ env.NPM_REGISTRY }}
github_ro_token: ${{ github.event.repository.private == true && secrets.DATAVISYN_BOT_REPO_TOKEN || github.token }}
run_webpack: ${{ inputs.node_run_webpack }}
#disable_cache: ${{ inputs.disable_cache }}
- name: Run Chromatic
if: ${{ inputs.chromatic_enable }}
uses: chromaui/[email protected]
Expand Down Expand Up @@ -172,7 +166,6 @@ jobs:
with:
python_version: ${{ secrets.PYTHON_VERSION || env.PYTHON_VERSION }}
github_ro_token: ${{ github.event.repository.private == true && secrets.DATAVISYN_BOT_REPO_TOKEN || github.token }}
#disable_cache: ${{ inputs.disable_cache }}
# If cypress is used, build node and python sequentially as it is avoiding the duplicate install overhead
build-node-python-cypress:
name: Node, Python, Cypress
Expand Down Expand Up @@ -236,13 +229,11 @@ jobs:
npm_registry: ${{ env.NPM_REGISTRY }}
github_ro_token: ${{ github.event.repository.private == true && secrets.DATAVISYN_BOT_REPO_TOKEN || github.token }}
run_webpack: false # Disable the build here and call afterwards, as otherwise the yarn run env:decrypt will fail due to a missing yarn install
#disable_cache: ${{ inputs.disable_cache }}
- name: Build python
uses: ./tmp/github-workflows/.github/actions/build-python
with:
python_version: ${{ secrets.PYTHON_VERSION || env.PYTHON_VERSION }}
github_ro_token: ${{ github.event.repository.private == true && secrets.DATAVISYN_BOT_REPO_TOKEN || github.token }}
disable_cache: true
- name: Decrypt .env.enc and <app>/.env.enc
run: |
yarn run env:decrypt -pass env:ENV_PASSWORD || true
Expand Down Expand Up @@ -358,13 +349,11 @@ jobs:
npm_registry: ${{ env.NPM_REGISTRY }}
github_ro_token: ${{ github.event.repository.private == true && secrets.DATAVISYN_BOT_REPO_TOKEN || github.token }}
run_webpack: false # Disable the build here and call afterwards, as otherwise the yarn run env:decrypt will fail due to a missing yarn install
#disable_cache: ${{ inputs.disable_cache }}
- name: Build python
uses: ./tmp/github-workflows/.github/actions/build-python
with:
python_version: ${{ secrets.PYTHON_VERSION || env.PYTHON_VERSION }}
github_ro_token: ${{ github.event.repository.private == true && secrets.DATAVISYN_BOT_REPO_TOKEN || github.token }}
#disable_cache: ${{ inputs.disable_cache }}
- name: Decrypt .env.enc and <app>/.env.enc
run: |
yarn run env:decrypt -pass env:ENV_PASSWORD || true
Expand Down

0 comments on commit c98b079

Please sign in to comment.