Skip to content

Commit

Permalink
Move build chromatic to build-node action
Browse files Browse the repository at this point in the history
  • Loading branch information
puehringer committed Jun 19, 2024
1 parent 9eeff55 commit 56d8621
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 12 deletions.
14 changes: 14 additions & 0 deletions .github/actions/build-node/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,14 @@ inputs:
run_webpack:
default: false
required: false
chromatic_enable:
description: 'Enable Chromatic tests'
required: false
type: boolean
default: false
chromatic_project_token:
description: 'Chromatic project token'
required: false

runs:
using: "composite"
Expand Down Expand Up @@ -107,3 +115,9 @@ runs:
with:
name: node-bundle
path: ./bundles
- name: Run Chromatic
if: ${{ inputs.chromatic_enable }}
uses: chromaui/[email protected]
with:
projectToken: ${{ inputs.chromatic_project_token }}

15 changes: 9 additions & 6 deletions .github/workflows/build-node-python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ on:
description: Unique id per workflow run. Must be set to unique value if dispatched multiple times for a single workflow.
default: ""
chromatic_enable:
description: 'Enable Chromatic Tests'
description: 'Enable Chromatic tests'
required: false
type: boolean
default: false
Expand Down Expand Up @@ -137,11 +137,8 @@ jobs:
github_ro_token: ${{ github.event.repository.private == true && secrets.DATAVISYN_BOT_REPO_TOKEN || github.token }}
run_webpack: ${{ inputs.node_run_webpack }}
enable_cache: ${{ inputs.runs_on != 'self-hosted' }}
- name: Run Chromatic
if: ${{ inputs.chromatic_enable }}
uses: chromaui/[email protected]
with:
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
chromatic_enable: ${{ inputs.chromatic_enable }}
chromatic_project_token: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}

build-python:
name: Python
Expand Down Expand Up @@ -219,6 +216,7 @@ jobs:
with:
ref: ${{ inputs.branch }}
token: ${{ github.event.repository.private == true && secrets.DATAVISYN_BOT_REPO_TOKEN || github.token }}
fetch-depth: ${{ inputs.chromatic_enable && '0' || '1' }}
- name: Checkout github-workflows
uses: actions/checkout@v4
with:
Expand All @@ -233,6 +231,8 @@ jobs:
github_ro_token: ${{ github.event.repository.private == true && secrets.DATAVISYN_BOT_REPO_TOKEN || github.token }}
run_webpack: false # Disable the build here and call afterwards, as otherwise the yarn run env:decrypt will fail due to a missing yarn install
enable_cache: ${{ inputs.cypress_runs_on != 'self-hosted' && inputs.runs_on != 'self-hosted' }}
chromatic_enable: ${{ inputs.chromatic_enable }}
chromatic_project_token: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
- name: Build python
uses: ./tmp/github-workflows/.github/actions/build-python
with:
Expand Down Expand Up @@ -338,6 +338,7 @@ jobs:
with:
ref: ${{ inputs.branch }}
token: ${{ github.event.repository.private == true && secrets.DATAVISYN_BOT_REPO_TOKEN || github.token }}
fetch-depth: ${{ inputs.chromatic_enable && '0' || '1' }}
- name: Checkout github-workflows
uses: actions/checkout@v4
with:
Expand All @@ -352,6 +353,8 @@ jobs:
github_ro_token: ${{ github.event.repository.private == true && secrets.DATAVISYN_BOT_REPO_TOKEN || github.token }}
run_webpack: false # Disable the build here and call afterwards, as otherwise the yarn run env:decrypt will fail due to a missing yarn install
enable_cache: ${{ inputs.playwright_runs_on != 'self-hosted' && inputs.runs_on != 'self-hosted' }}
chromatic_enable: ${{ inputs.chromatic_enable }}
chromatic_project_token: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
- name: Build python
uses: ./tmp/github-workflows/.github/actions/build-python
with:
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/build-node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
required: false
default: ${{ github.ref || github.head_ref }}
chromatic_enable:
description: 'Enable Chromatic Tests'
description: 'Enable Chromatic tests'
required: false
type: boolean
default: false
Expand All @@ -26,6 +26,8 @@ on:
required: false
NODE_VERSION:
required: false
CHROMATIC_PROJECT_TOKEN:
required: false

env:
NPM_REGISTRY: "https://registry.npmjs.org/"
Expand Down Expand Up @@ -70,8 +72,5 @@ jobs:
github_ro_token: ${{ github.event.repository.private == true && secrets.DATAVISYN_BOT_REPO_TOKEN || github.token }}
run_webpack: ${{ inputs.node_run_webpack }}
enable_cache: ${{ inputs.runs_on != 'self-hosted' }}
- name: Run Chromatic
if: ${{ inputs.chromatic_enable }}
uses: chromaui/[email protected]
with:
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
chromatic_enable: ${{ inputs.chromatic_enable }}
chromatic_project_token: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}

0 comments on commit 56d8621

Please sign in to comment.