Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for eventjson to v3 simplehash hash #7

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Add support for eventjson to v3 simplehash hash #7

merged 1 commit into from
Jan 31, 2024

Conversation

honourfish
Copy link
Contributor

Overview

  • Add ability to generate a v3 hash directly from event json
  • refactor the options to take the respective v2/v3 event object rather than the proto object
  • refactor the publicFromPrivate v3 option to not try and set the assetIdentity.

Testing

  • added unit tests for options for v2 and v3 schema

re: AB#9030

robinbryce
robinbryce approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, useful addition. thanks!

@honourfish honourfish merged commit bdcf623 into main Jan 31, 2024
1 check passed
@honourfish honourfish deleted the dev/jgough/9030-event-json-hash branch January 31, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinbryce robinbryce robinbryce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@honourfish @robinbryce