feat: support VDS requested assignment 3 from MMRIVER 02 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2024 12:25
When replicating the remote log file and the remote seal to local disc the files must be opened in O_TRUNC mode. The single corner case where this happens required file system based tests and we only have those in veracity. Follow on work required if we want those tests to exist in this repo. AB#10163
The presigned receipts will use VDS=3 once the merklesealer takes this change. Impact Receipt verifiers will need accept VDS 3. Receipt verifiers can confirm the VDS to expect by examining any replica's latest seal. Receipt verifiers can safely accept both VDS 2 or VS3 if they know out of band the receipt came from a forestrie log. Receipt creators *may* need to accomodate the VDS change, depending on the depth of validation and sanity checking they perform on pre-signed receipts before attaching proofs. This change does not affect: * replication via veracity. * checkpoint verification.
robinbryce
requested review from
eccles,
wp0pw,
JAG-UK,
honourfish and
henry739
honourfish
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The presigned receipts will use VDS=3 once the merklesealer takes this
change.
Impact
replica's latest seal.
of band the receipt came from a forestrie log.
the depth of validation and sanity checking they perform on pre-signed
receipts before attaching proofs.
This change has no impact on: