-
Notifications
You must be signed in to change notification settings - Fork 139
Re-add OnDiskGraphIndex::getDimension #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
ac1226f to
2cc3335
Compare
|
@marianotepper - I ran |
|
@michaeljmarshall reran the failed tests this morning and everything passed. I'm not sure why a unit test failed initially but it doesn't appear to have anything to do with the content of this PR |
jvector-base/src/main/java/io/github/jbellis/jvector/graph/disk/OnDiskGraphIndex.java
Show resolved
Hide resolved
|
Moving forward, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This
getDimensionmethod was removed from theOnDiskGraphIndexclass via #536. We use it in C*, so I propose adding it back in since it is a getter on a final field.