Skip to content

Conversation

@michaeljmarshall
Copy link
Member

This getDimension method was removed from the OnDiskGraphIndex class via #536. We use it in C*, so I propose adding it back in since it is a getter on a final field.

@github-actions
Copy link
Contributor

Before you submit for review:

  • Does your PR follow guidelines from CONTRIBUTIONS.md?
  • Did you summarize what this PR does clearly and concisely?
  • Did you include performance data for changes which may be performance impacting?
  • Did you include useful docs for any user-facing changes or features?
  • Did you include useful javadocs for developer oriented changes, explaining new concepts or key changes?
  • Did you trigger and review regression testing results against the base branch via Run Bench Main?
  • Did you adhere to the code formatting guidelines (TBD)
  • Did you group your changes for easy review, providing meaningful descriptions for each commit?
  • Did you ensure that all files contain the correct copyright header?

If you did not complete any of these, then please explain below.

@michaeljmarshall michaeljmarshall changed the title Add AbstractGraphIndexWriter::getDimension Re-add OnDiskGraphIndex::getDimension Oct 17, 2025
@michaeljmarshall
Copy link
Member Author

@marianotepper - I ran mvn clean test locally and all (unit?) tests passed, but it appears I do not have permission to retry the failure, which appears unrelated.

@MarkWolters
Copy link
Contributor

@michaeljmarshall reran the failed tests this morning and everything passed. I'm not sure why a unit test failed initially but it doesn't appear to have anything to do with the content of this PR

@marianotepper
Copy link
Contributor

Moving forward, OnDiskGraphIndex should not be used externally anymore. The interface ImmutableGraphIndex should be used exclusively, following #534. We can add the getDimension method to ImmutableGraphIndex, which would be equivalent to the requested change.

Copy link
Contributor

@marianotepper marianotepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jshook jshook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marianotepper marianotepper merged commit 32ba41b into main Oct 22, 2025
25 of 32 checks passed
@marianotepper marianotepper deleted the add-dimension-getter branch October 22, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants