Initial implementation of a react agent #187
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-dr
reviewed
Oct 20, 2025
Comment on lines
+254
to
+267
| class IntrospectiveAgentWorker(Workflow): | ||
| pass | ||
|
|
||
|
|
||
| class ToolInteractiveReflectionAgentWorker(Workflow): | ||
| pass | ||
|
|
||
|
|
||
| class LATSAgentWorker(Workflow): | ||
| pass | ||
|
|
||
|
|
||
| class CoAAgentPack(Workflow): | ||
| pass |
There was a problem hiding this comment.
I propose that we just get rid of these 'legacy' agents. I don't think it's worth re-implementing them in the new framework.
There was a problem hiding this comment.
should I delete them now before ugrading? I will do that as a PR first
alex-dr
reviewed
Oct 20, 2025
Comment on lines
+44
to
+45
| class ReActAgent(Workflow): | ||
| """Implement of RAG using a ReAcT Agent""" |
There was a problem hiding this comment.
https://developers.llamaindex.ai/python/examples/agent/react_agent/#run-some-queries
Add a comment to the docstring about how this is different from the builtin react agent
alex-dr
reviewed
Oct 20, 2025
| # Backwards compatibility which used chat | ||
| loop = asyncio.get_event_loop() | ||
| if loop.is_running(): | ||
| raise RuntimeError() |
There was a problem hiding this comment.
Add a message to the error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.