Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reintroduce text combinator #165

Merged

Conversation

Philipp-Binder
Copy link
Contributor

@Philipp-Binder Philipp-Binder commented Sep 30, 2024

Solves #86

Hi,

I saw that #86 is marked 'up-for-grabs' while migrating dotnet-env from Sprache to superpower (tonerdo/dotnet-env#106).
I additionally added the shorthand for TextSpans too, guess that would be helpful too.

Let me know if code/tests/comments are okay that way.

@nblumhardt
Copy link
Member

Looks good, thanks @Philipp-Binder 👍

@nblumhardt nblumhardt merged commit 92a1909 into datalust:dev Sep 30, 2024
1 check passed
@Philipp-Binder Philipp-Binder deleted the feature/reintroduce-TextCombinator branch September 30, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants