Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDFCLOUD-2509 Add JSON Payload Java samples #63

Merged
merged 5 commits into from
Jan 2, 2024

Conversation

datalogics-tsmith
Copy link
Contributor

Continuing from #62 to add more samples

When writing the new samples a few of them took longer than the
default timeout and needed to be bumped up so for consistency I added
the timeout increase to all of them
Copy link
Member

@datalogics-kam datalogics-kam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new JSON Payload directory needs a pom.xml; you can probably copy it from the Multipart Payload directory without changes; most likely it'll work since Maven POMs use configuration-by-convention; it'll just find your sources.

My bad, I didn't see it in the GitHub file list, but it was there in the checkout.

Then, the GitHub Action to run mvn verify needs another step here...just run mvn with the new directory as well. To make it easy to see in the logs, make it another step, like:

diff --git a/.github/workflows/verify-java.yml b/.github/workflows/verify-java.yml
index 80e53d5..bc53ada 100644
--- a/.github/workflows/verify-java.yml
+++ b/.github/workflows/verify-java.yml
@@ -23,5 +23,7 @@ jobs:
             # The "Build with Maven" step runs the Maven `verify` target in non-interactive mode to ensure that your
             # code builds, tests pass, and a package can be created.
             # The -f option indicates the root of the Maven project, where the pom.xml is located
-            -   name: Build with Maven
+            -   name: Build Multipart Payload examples with Maven
                 run: mvn -f 'Java/Endpoint Examples/Multipart Payload' --show-version --batch-mode --update-snapshots verify
+            -   name: Build JSON Payload examples with Maven
+                run: mvn -f 'Java/Endpoint Examples/JSON Payload' --show-version --batch-mode --update-snapshots verify

That'll make sure the code is checked in CI.

Copy link
Contributor

@datalogics-cgreen datalogics-cgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge this PR to get both sets of single calls in.

EDIT: My mistake – that's not quite what happened, but the merge is still good.

@datalogics-cgreen datalogics-cgreen merged commit 0cf3cb4 into datalogics:main Jan 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants