-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude VCS files et al. from Debian source package; explicitly declare Debian source format version #197
Conversation
.git/
from Debian source package
.git/
from Debian source package+extend-diff-ignore = "(^|/)(\.github|clients|patches)($|/)" | ||
+tar-ignore = .github | ||
+tar-ignore = clients | ||
+tar-ignore = patches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @joeyh -- would you mind if we move away from git source for git-annex? There is a security consideration (I will forward email).
Merging for now as is since works and would mitigate immediate security hazard. |
If i recall correctly, usually when one is building a debian source package from a git repository, it's typical to use dpkg-buildpackage -I, which excludes the .git directory. Still it might be a reasonable belt and suspenders thing to ignore .git in debian/source/options I am much more doubtful about putting ignores specific to some github CI thing in there, because I don't use it, don't know how I would maintain it, and don't want to be on the hook for maintaining similar things for any other similar CI system that might be used. Is the ignore of "clients" and "patches" to do with github CI or part of your build process? Have you considered an alternative of creating a clean tree with only the files from git and building in there? eg
(Note for my future reference, see email with message-id Zcun7-vjJ5R1zEvO@bilena for context not mentioned in this bug report.) |
@joeyh Also, I don't believe building inside a untarred git archive would work, as the build process needs to get the current |
This PR adds a patch to
git-annex
that does the following:Configures the Debian source package builds to exclude common VCS files, along with excluding some non-
git-annex
files that are present for this repository's buildsDeclares the Debian source package format to be "1.0"; declaring the format explicitly is highly recommended
@yarikoptic Once we confirm this works properly, we should submit this patch upstream to @joeyh.