-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of 2D Raman block #936
Open
ml-evs
wants to merge
7
commits into
main
Choose a base branch
from
ml-evs/raman-map
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
added
enhancement
New feature or request
datablock
An issue pertaining to a specific datablock
labels
Oct 15, 2024
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #936 +/- ##
==========================================
- Coverage 68.38% 67.30% -1.08%
==========================================
Files 62 64 +2
Lines 3928 4034 +106
==========================================
+ Hits 2686 2715 +29
- Misses 1242 1319 +77
|
datalab Run #2589
Run Properties:
|
Project |
datalab
|
Run status |
Passed #2589
|
Run duration | 06m 36s |
Commit |
4cad5ea235 ℹ️: Merge 2dcf37155b6bcc7d3bd602e3b08482f06e141e81 into 21ed72d35f6b26d3670d1bfba22a...
|
Committer | Matthew Evans |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
396
|
ml-evs
force-pushed
the
ml-evs/raman-map
branch
from
October 15, 2024 22:58
d45c0e6
to
c96bd24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a transplant of @elbee99's work in #782, and closes #781.
There's a few things to iron out, but I think this is ready to merge -- I will add a little block warning that just says to be wary of the alignment.