Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of 2D Raman block #936

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Implementation of 2D Raman block #936

wants to merge 7 commits into from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Oct 15, 2024

This PR is a transplant of @elbee99's work in #782, and closes #781.

There's a few things to iron out, but I think this is ready to merge -- I will add a little block warning that just says to be wary of the alignment.

@ml-evs ml-evs added enhancement New feature or request datablock An issue pertaining to a specific datablock labels Oct 15, 2024
@ml-evs ml-evs mentioned this pull request Oct 15, 2024
@ml-evs ml-evs added this to the v0.5.x milestone Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 27.35849% with 77 lines in your changes missing coverage. Please review.

Project coverage is 67.30%. Comparing base (21ed72d) to head (2dcf371).

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/apps/raman_map/blocks.py 25.24% 77 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
- Coverage   68.38%   67.30%   -1.08%     
==========================================
  Files          62       64       +2     
  Lines        3928     4034     +106     
==========================================
+ Hits         2686     2715      +29     
- Misses       1242     1319      +77     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/apps/raman_map/__init__.py 100.00% <100.00%> (ø)
pydatalab/src/pydatalab/blocks/__init__.py 100.00% <100.00%> (ø)
pydatalab/src/pydatalab/blocks/common.py 60.81% <ø> (ø)
pydatalab/src/pydatalab/apps/raman_map/blocks.py 25.24% <25.24%> (ø)

Copy link

cypress bot commented Oct 15, 2024

datalab    Run #2589

Run Properties:  status check passed Passed #2589  •  git commit 4cad5ea235 ℹ️: Merge 2dcf37155b6bcc7d3bd602e3b08482f06e141e81 into 21ed72d35f6b26d3670d1bfba22a...
Project datalab
Run status status check passed Passed #2589
Run duration 06m 36s
Commit git commit 4cad5ea235 ℹ️: Merge 2dcf37155b6bcc7d3bd602e3b08482f06e141e81 into 21ed72d35f6b26d3670d1bfba22a...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 396

@ml-evs ml-evs modified the milestones: v0.5.x, v0.6.x Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datablock An issue pertaining to a specific datablock enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling 2D Raman maps
2 participants