-
Notifications
You must be signed in to change notification settings - Fork 27
Restructure CI and add DevContainer build automation #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @guzman-raphael! In the proposed environments, one cannot locally run workflow-calcium-imaging
with an editable version of element-calcium-imaging
. I had set up the local-test
environment to allow me to make edits to element-calcium-imaging
locally and run the pytests. In the local-test/devcontainer.json
, I added pip install -e ../element-calcium-imaging
to allow for this:
"onCreateCommand": "pip install -r ./requirements_dev.txt && pip install -e . && pip install -e ../element-calcium-imaging && MYSQL_VER=8.0 docker compose down && MYSQL_VER=8.0 docker compose up --build --wait"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @guzman-raphael! Going ahead with the merge since we are exploring an option to migrate the contents of the workflow
to the element
, and thus my above comment won't be a requirement.
Primarily this simplifies the CI to a design that enables composability with reusable GHA jobs.
Prebuilt image is now implemented and should reduce build errors others have reported. First Codespace build took ~2m30s for me (reduced since it pulls an image now).
Also, I did remove some features since it was unclear why they were needed when reviewing prior PR's. Happy to discuss if I am missing something.