This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Restructure CI and add DevContainer build automation #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabilar
suggested changes
May 17, 2023
There was a problem hiding this comment.
Thanks @guzman-raphael! In the proposed environments, one cannot locally run workflow-calcium-imaging with an editable version of element-calcium-imaging. I had set up the local-test environment to allow me to make edits to element-calcium-imaging locally and run the pytests. In the local-test/devcontainer.json, I added pip install -e ../element-calcium-imaging to allow for this:
"onCreateCommand": "pip install -r ./requirements_dev.txt && pip install -e . && pip install -e ../element-calcium-imaging && MYSQL_VER=8.0 docker compose down && MYSQL_VER=8.0 docker compose up --build --wait"
kabilar
approved these changes
May 19, 2023
There was a problem hiding this comment.
Thanks @guzman-raphael! Going ahead with the merge since we are exploring an option to migrate the contents of the workflow to the element, and thus my above comment won't be a requirement.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily this simplifies the CI to a design that enables composability with reusable GHA jobs.
Prebuilt image is now implemented and should reduce build errors others have reported. First Codespace build took ~2m30s for me (reduced since it pulls an image now).
Also, I did remove some features since it was unclear why they were needed when reviewing prior PR's. Happy to discuss if I am missing something.