Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using cluster domain suffix for DruidIngestion #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StephenLasseter
Copy link

Fixes #213.

Description

GetRouterSvcUrl in druidapi.go hard-codes cluster.local as a domain suffix. This breaks DruidIngestion for Kubernetes clusters that use a custom cluster name. But, given that GetRouterSvcUrl will be called within the same namespace as the router service, there is no need to use a fully qualified name. By using the relative name, we avoid needing to look up what domain suffix to use.

This patch removes svc.cluster.local from the URL of the Druid router service returned by GetRouterSvcUrl.

If this patch is rejected for not using the fqdn, then we need to dynamically look up the current cluster domain rather than assume it is cluster.local.


This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Key changed/added files in this PR
  • pkg/druidapi/druidapi.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DruidIngestion fails for k8s clusters that set clusterDomain
1 participant