Stop using cluster domain suffix for DruidIngestion #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213.
Description
GetRouterSvcUrl in druidapi.go hard-codes cluster.local as a domain suffix. This breaks DruidIngestion for Kubernetes clusters that use a custom cluster name. But, given that GetRouterSvcUrl will be called within the same namespace as the router service, there is no need to use a fully qualified name. By using the relative name, we avoid needing to look up what domain suffix to use.
This patch removes
svc.cluster.local
from the URL of the Druid router service returned by GetRouterSvcUrl.If this patch is rejected for not using the fqdn, then we need to dynamically look up the current cluster domain rather than assume it is
cluster.local
.This PR has:
Key changed/added files in this PR
pkg/druidapi/druidapi.go