Skip to content

Conversation

@chriscollins3456
Copy link
Collaborator

This PR brings some commits to OSS that are needed for polish around the file upload/download experience:

  • fix(s3) Cache S3Presigner to prevent connection pool shutdown errors
  • fix(ui) Fix uploading images with spaces in them
  • feat(ui) Improve docs image upload experience with new file upload flow
  • fix(files) Properly separate user uploaded file names from GUID
  • feat(files) Extend supported file types after consulting with Claude

It also sneaks one other commit that needs to be brought to OSS since i'm doing a roundup PR anyways:

  • fix(ui) Fix viewing domain hierarchy view with view auth

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Oct 31, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 31, 2025
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Oct 31, 2025

✅ Meticulous spotted 0 visual differences across 1016 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit cb37bb8. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Bundle Report

Changes will increase total bundle size by 2.63kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.58MB 2.63kB (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 2.63kB 18.96MB 0.01%

Files in assets/index-*.js:

  • ./src/alchemy-components/components/Editor/toolbar/AddImageButtonV2.tsx → Total Size: 2.71kB

  • ./src/alchemy-components/components/Editor/extensions/fileDragDrop/fileUtils.ts → Total Size: 4.96kB

  • ./src/alchemy-components/components/Editor/toolbar/FileUploadButton.tsx → Total Size: 1.19kB

  • ./src/alchemy-components/components/Editor/toolbar/Toolbar.tsx → Total Size: 4.29kB

  • ./src/app/shared/hooks/useFileUpload.ts → Total Size: 1.45kB

  • ./src/alchemy-components/components/Editor/extensions/htmlToMarkdown.tsx → Total Size: 4.78kB

  • ./src/app/homeV3/modules/hierarchyViewModule/components/domains/hooks/useDomainsByUrns.ts → Total Size: 850 bytes

  • ./src/alchemy-components/components/Editor/toolbar/FileUploadContent.tsx → Total Size: 3.34kB

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 78.87324% with 15 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...n/java/com/linkedin/metadata/utils/aws/S3Util.java 65.38% 8 Missing and 1 partial ⚠️
...odule/components/domains/hooks/useDomainsByUrns.ts 14.28% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Nov 3, 2025
@chriscollins3456 chriscollins3456 merged commit 5ab063f into master Nov 3, 2025
44 checks passed
@chriscollins3456 chriscollins3456 deleted the cc--file-upload-combined-commits branch November 3, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops PR or Issue related to DataHub backend & deployment pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants