-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat(ui): Modernize Analytics Page with v2/Alchemy Components (#6872) #15068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: cclaude-session <[email protected]> Co-authored-by: Claude <[email protected]>
|
✅ Meticulous spotted 0 visual differences across 1006 screens tested: view results. Meticulous evaluated ~8 hours of user flows against your PR. Expected differences? Click here. Last updated for commit aca3590. This comment will update as new commits are pushed. |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Bundle ReportChanges will increase total bundle size by 28.82kB (0.1%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Modernizes the Analytics page (
/analyticsroute) with v2/Alchemy components, bringing it up to spec with the modern design system used in the Observe module's Stats tab.Changes
Components Modernized
1. Highlight.tsx
CardandTypographycomponents with manual stylingCardandTextcomponents2. ChartGroup.tsx
Typography.TitlewithDividerPageTitlecomponent withsectionHeadervariant3. AnalyticsChart.tsx
ChartCard,ChartContainer)GraphCard+LineChart/BarChartcomponents4. AnalyticsPage.tsx
Loadercomponent instead of legacyMessageVisual Changes
Layout & Styling
auto-fitgridCharts
Typography
TextcomponentTesting
Technical Details
Data Transformation
Charts now properly transform backend data formats to work with Alchemy components:
{x: timestamp, y: value}formatType Safety
anytypesDesign System Alignment
Follows patterns from:
entityV2/shared/tabs/Dataset/Stats/StatsTabV2/entityV2/shared/graphs/RowCountGraph.tsxBreaking Changes
None - this is a purely visual update maintaining all existing functionality and GraphQL queries.
Screenshots
The analytics page now has a modern, consistent design matching the rest of DataHub's v2 UI.
Checklist