Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown image syntax per issue #293 #295

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

naupaka
Copy link
Member

@naupaka naupaka commented Oct 17, 2024

Closes #293 (hopefully)

Copy link

github-actions bot commented Oct 17, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/genomics-r-intro/compare/md-outputs..md-outputs-PR-295

The following changes were observed in the rendered markdown documents:

 01-r-basics.md                  |  2 +-
 03-basics-factors-dataframes.md | 10 +++++-----
 md5sum.txt                      |  4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-10-17 18:32:03 +0000

github-actions bot pushed a commit that referenced this pull request Oct 17, 2024
@naupaka naupaka merged commit cf1a602 into datacarpentry:main Oct 17, 2024
3 checks passed
@naupaka naupaka deleted the fix-images branch October 17, 2024 18:39
github-actions bot pushed a commit that referenced this pull request Oct 17, 2024
Auto-generated via `{sandpaper}`
Source  : cf1a602
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-10-17 18:39:23 +0000
Message : Merge pull request #295 from naupaka/fix-images

Fix markdown image syntax per issue #293
github-actions bot pushed a commit that referenced this pull request Oct 17, 2024
Auto-generated via `{sandpaper}`
Source  : 81ac777
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-17 18:40:54 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : cf1a602
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-10-17 18:39:23 +0000
Message : Merge pull request #295 from naupaka/fix-images

Fix markdown image syntax per issue #293
github-actions bot pushed a commit that referenced this pull request Oct 22, 2024
Auto-generated via `{sandpaper}`
Source  : 81ac777
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-17 18:40:54 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : cf1a602
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-10-17 18:39:23 +0000
Message : Merge pull request #295 from naupaka/fix-images

Fix markdown image syntax per issue #293
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
Auto-generated via `{sandpaper}`
Source  : 81ac777
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-17 18:40:54 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : cf1a602
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-10-17 18:39:23 +0000
Message : Merge pull request #295 from naupaka/fix-images

Fix markdown image syntax per issue #293
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
Auto-generated via `{sandpaper}`
Source  : 81ac777
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-17 18:40:54 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : cf1a602
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-10-17 18:39:23 +0000
Message : Merge pull request #295 from naupaka/fix-images

Fix markdown image syntax per issue #293
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
Auto-generated via `{sandpaper}`
Source  : 81ac777
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-17 18:40:54 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : cf1a602
Branch  : main
Author  : Naupaka Zimmerman <[email protected]>
Time    : 2024-10-17 18:39:23 +0000
Message : Merge pull request #295 from naupaka/fix-images

Fix markdown image syntax per issue #293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lesson1: image not rendered
1 participant