Make link to issue template url safe #3508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
|
✅ 58/58 passed, 2 skipped, 29m15s total Running from acceptance #7958 |
asnare
requested changes
Jan 10, 2025
| @@ -96,7 +97,7 @@ def _definitely_failure(source_code: str, e: Exception) -> MaybeTree: | |||
| end_col=(e.error.end_offset or 2) - 1, | |||
| ), | |||
| ) | |||
| new_issue_url = ( | |||
| new_issue_url = urllib.parse.quote_plus( | |||
There was a problem hiding this comment.
Please check the URL produced by this. :) (I think it is mangled and does not work?)
I think the problem here is:
- The
quote()andquote_plus()methods are intended only quoting/escaping individual path and query parameter components of a URL, not the whole thing. For example, the scheme ends up being encoded ashttps:%3A%2F%2fby this. - The query parameters in this URL are already quoted/escaped: that's why the various
+bits are in the title parameter already, as well as all the%-encoded bits and pieces. (In the first generation of web servers this was the encoding used for form parameters, before UTF-8 and%-encodingcame along).
Looking at the context, I suspect you only intended to escape the source code being inserted into the URL, not the already-escaped URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Make link to issue template url safe using Python's urllib
Linked issues
Introduced in #3498