-
Couldn't load subscription status.
- Fork 77
Improve oracle support in reconcile #2081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ 46/46 passed, 6 flaky, 3m25s total Flaky tests:
Running from acceptance #2800 |
9a064af to
accda3a
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2081 +/- ##
==========================================
+ Coverage 64.87% 64.92% +0.04%
==========================================
Files 96 96
Lines 7895 7908 +13
Branches 821 822 +1
==========================================
+ Hits 5122 5134 +12
- Misses 2593 2595 +2
+ Partials 180 179 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Small nit around NVARCHAR handling.
src/databricks/labs/lakebridge/reconcile/query_builder/expression_generator.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
What does this PR do?
RAWTOHEX(...), 2withUTL_I18N.STRING_TO_RAW(...,'AL32UTF8'), 4(SHA-256).Linked issues
Resolves #2057
Functionality
Tests