Add method to upload DuckDB files to Unity Catalog Volume with tests #2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radhikaathalye-db
had a problem deploying
to
tool
GitHub Actions
Failure
radhikaathalye-db
requested review from
goodwillpunning,
gueniai and
sundarshankar89
and removed request for
a team
|
❌ 20/27 passed, 7 failed, 1m7s total ❌ test_upload_duckdb_to_uc_volume_success: TypeError: DashboardManager.__init__() missing 1 required positional argument: 'dashboard_deployer' (106ms)❌ test_upload_duckdb_to_uc_volume_failure: TypeError: DashboardManager.__init__() missing 1 required positional argument: 'dashboard_deployer' (1ms)❌ test_upload_duckdb_to_uc_volume_file_not_found: TypeError: DashboardManager.__init__() missing 1 required positional argument: 'dashboard_deployer' (113ms)❌ test_upload_duckdb_to_uc_volume_invalid_volume_path: TypeError: DashboardManager.__init__() missing 1 required positional argument: 'dashboard_deployer' (1ms)❌ test_transpiles_all_dbt_project_files: ValueError: No such transpiler: Morpheus (688ms)❌ test_transpile_sql_file: ValueError: No such transpiler: Morpheus (649ms)❌ test_transpile_sql_file: AssertionError (9.31s)Running from acceptance #2412 |
|
|
||
| # Validate inputs | ||
| if not os.path.exists(local_file_path): | ||
| print(f"Error: Local file not found: {local_file_path}") |
There was a problem hiding this comment.
We'll want to use logger.error() statements here as opposed to printing to the console. Here is a good reference: https://github.com/databrickslabs/lakebridge/blob/main/src/databricks/labs/lakebridge/assessments/configure_assessment.py#L43
src/databricks/labs/lakebridge/assessments/dashboards/dashboard_manager.py
Show resolved
Hide resolved
| url = f"{workspace_url}/api/2.0/fs/files{volume_path}" | ||
|
|
||
| with open(local_file_path, 'rb') as f: | ||
| response = requests.put(url, headers=headers, data=f) |
There was a problem hiding this comment.
@radhikaathalye-db could you pull the upstream changes from the branch feature/add_local_dashboards. We'll want to use the Python SDK (WorkspaceClient) to upload files to the UC volume vs. using the REST API. Thanks!
radhikaathalye-db
had a problem deploying
to
tool
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
Add a new method to the DashboardManager class to upload DuckDB extract to UC volume. Add tests for the same.
Relevant implementation details
Caveats/things to watch out for when reviewing:
Linked issues
Resolves #..
Functionality
databricks labs lakebridge ...Tests