Open
Conversation
Contributor
|
I thought that we decided to go into the approach of this being like a default thing? With a global ZerobusStream that would act as a single or as MultiplexStream depending on the feature? Is there any specific reason you decided not to? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Added a MultiplexedStream abstraction that manages N sub-streams behind the scenes. Records are distributed
across streams via round-robin, giving customers higher throughput with a simple API.
through a single tower Buffer worker - cloning the channel shares the same connection. I changed ZerobusSdk
to create a new channel per create_stream call so each stream gets its own TCP connection, enabling true
parallel ingestion and ack processing.
healthy streams best-effort, collects all unacked records, and blocks further ingestion. Callers can
retrieve unacked records via get_unacked_records().
/ ingest_records. Callers use wait_for_message_id to await acknowledgment. This makes it clear that these
IDs are not ordered offsets.
All current changes are currently guarded by "testing" flag
How is this tested?
New unit test suite, benchmarked performance increase