[Feature] Add `databricks_app` resource #4099

nkvuong · 2024-10-12T10:22:44Z

Changes

Added databricks_app resource

Resolves #4084

Tests

make test run locally
relevant change in docs/ folder
covered with integration tests in internal/acceptance
relevant acceptance tests are passing
using Go SDK

alexott

small changes in the doc required, otherwise code looks good

apps/resource_app.go

docs/resources/app.md

andrewnester · 2024-11-14T10:44:28Z

apps/resource_app.go

+				return err
+			}
+			// now deploy the app, using the source code path
+			createAppDeployment.AppName = app.Name


I think we discussed it offline and agreed that the deployment won't be part of TF configuration. Instead, if an users want to deploy, they use CLI to do that. Otherwise it's confusing because we do the deployments only when source_code_path changed but we need to do deployments when source code is changed.

@pietern wdyt?

andrewnester · 2024-11-14T10:44:50Z

apps/resource_app.go

+			if err != nil {
+				return err
+			}
+			if d.HasChanges("source_code_path", "mode") {


See my comment above, I think we should remove app deployment altogether for now

pietern · 2024-11-20T20:22:21Z

apps/resource_app.go

+func (appStruct) CustomizeSchema(s *common.CustomizableSchema) *common.CustomizableSchema {
+
+	// Required fields & validation
+	s.SchemaPath("name").SetRequired().SetForceNew().SetValidateFunc(validation.StringMatch(regexp.MustCompile("^[a-z-]{2,30}$"), "name must contain only lowercase alphanumeric characters and hyphens, and be between 2 and 30 characters long"))


Style: this line is very long

apps/resource_app.go

pietern · 2024-11-20T20:31:07Z

apps/resource_app.go

+		"update_time", "updater", "url"} {
+		s.SchemaPath(p).SetComputed()
+	}
+	return s


Could we add this constraint back, where you cannot have more than one defined per resource?

apps/resource_app.go

docs/resources/app.md

apps/resource_app.go

andrewnester

I've just realised that there's an important piece is missing: we need to supporting setting permissions for app resource as we do for other resources (see ResourcePermissions). Apps do support this API https://docs.databricks.com/api/workspace/apps/setpermissions

alexott · 2024-11-21T12:29:16Z

@andrewnester maybe we can do it in a separate PR?

andrewnester · 2024-11-21T12:53:47Z

@alexott we could, but having this permissions management for app is critical for DABs anyway, so I'd rather have it in this PR too. @pietern wdyt?

andrewnester · 2024-11-21T12:58:20Z

Just to clarify, I mean app resource needs to be added here so it can be part of the schema and be able to use it by DABs since we rely on generic databricks_permission resource anyway
https://github.com/databricks/terraform-provider-databricks/blob/main/permissions/permission_definitions.go#L346

…-provider-databricks into feature/app

github-actions · 2024-11-22T08:11:20Z

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

PR number: 4099
Commit SHA: 9e41c692be0ebba3b34aa7e092b4ca9532d0d967

Checks will be approved automatically on success.

eng-dev-ecosystem-bot · 2024-11-22T08:13:00Z

Test Details: go/deco-tests/11968854526

nkvuong · 2024-11-22T08:13:22Z

@andrewnester makes sense - I've added apps to the permission resource and corresponding tests

nkvuong and others added 5 commits October 12, 2024 18:22

added databricks_app resource

c8859e2

wip

962d9f2

add doc

2e9137a

alias

91b5166

Merge branch 'main' into feature/app

bcf2a97

nkvuong temporarily deployed to test-trigger-is October 29, 2024 09:48 — with GitHub Actions Inactive

nkvuong marked this pull request as ready for review October 29, 2024 09:48

nkvuong requested review from a team as code owners October 29, 2024 09:48

nkvuong requested review from mgyucht and removed request for a team October 29, 2024 09:48

fix

35b85eb

nkvuong temporarily deployed to test-trigger-is October 29, 2024 09:59 — with GitHub Actions Inactive

fix test

9c7ad60

nkvuong temporarily deployed to test-trigger-is October 30, 2024 06:25 — with GitHub Actions Inactive

fix test

863fa37

nkvuong temporarily deployed to test-trigger-is October 30, 2024 08:41 — with GitHub Actions Inactive

fix

2d7b38c

nkvuong temporarily deployed to test-trigger-is October 30, 2024 12:54 — with GitHub Actions Inactive

alexott requested changes Nov 6, 2024

View reviewed changes

apps/resource_app.go Outdated Show resolved Hide resolved

docs/resources/app.md Outdated Show resolved Hide resolved

docs/resources/app.md Outdated Show resolved Hide resolved

andrewnester reviewed Nov 14, 2024

View reviewed changes

andrewnester requested a review from pietern November 14, 2024 10:46

Merge branch 'main' into feature/app

b733ee9

nkvuong temporarily deployed to test-trigger-is November 14, 2024 11:07 — with GitHub Actions Inactive

feedback

ff8bee8

nkvuong temporarily deployed to test-trigger-is November 14, 2024 11:36 — with GitHub Actions Inactive

fix test

0daeea1

nkvuong temporarily deployed to test-trigger-is November 15, 2024 00:07 — with GitHub Actions Inactive

pietern reviewed Nov 20, 2024

View reviewed changes

feedback

be96f91

nkvuong temporarily deployed to test-trigger-is November 21, 2024 02:03 — with GitHub Actions Inactive

nkvuong temporarily deployed to test-trigger-is November 21, 2024 02:04 — with GitHub Actions Inactive

alexott approved these changes Nov 21, 2024

View reviewed changes

apps/resource_app.go Show resolved Hide resolved

andrewnester requested review from andrewnester, alexott and pietern November 21, 2024 12:24

andrewnester reviewed Nov 21, 2024

View reviewed changes

andrewnester self-requested a review November 21, 2024 12:58

andrewnester mentioned this pull request Nov 21, 2024

Added support for Databricks Apps in DABs databricks/cli#1928

Open

2 tasks

add app permission

8338d09

nkvuong temporarily deployed to test-trigger-is November 22, 2024 02:38 — with GitHub Actions Inactive

Merge branch 'main' into feature/app

c6ee7ea

nkvuong temporarily deployed to test-trigger-is November 22, 2024 02:38 — with GitHub Actions Inactive

nkvuong added 2 commits November 22, 2024 11:29

fix test

07ea8b7

Merge branch 'feature/app' of https://github.com/databricks/terraform…

3b1f6e2

…-provider-databricks into feature/app

nkvuong temporarily deployed to test-trigger-is November 22, 2024 03:30 — with GitHub Actions Inactive

more computed fields

9e41c69

nkvuong temporarily deployed to test-trigger-is November 22, 2024 08:11 — with GitHub Actions Inactive

alexott approved these changes Nov 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Add `databricks_app` resource #4099

[Feature] Add `databricks_app` resource #4099

nkvuong commented Oct 12, 2024 •

edited

Loading

alexott left a comment

andrewnester Nov 14, 2024

andrewnester Nov 14, 2024

pietern Nov 20, 2024

pietern Nov 20, 2024

andrewnester left a comment

alexott commented Nov 21, 2024

andrewnester commented Nov 21, 2024

andrewnester commented Nov 21, 2024

github-actions bot commented Nov 22, 2024

eng-dev-ecosystem-bot commented Nov 22, 2024

nkvuong commented Nov 22, 2024

[Feature] Add databricks_app resource #4099

Are you sure you want to change the base?

[Feature] Add databricks_app resource #4099

Conversation

nkvuong commented Oct 12, 2024 • edited Loading

Changes

Tests

alexott left a comment

Choose a reason for hiding this comment

andrewnester Nov 14, 2024

Choose a reason for hiding this comment

andrewnester Nov 14, 2024

Choose a reason for hiding this comment

pietern Nov 20, 2024

Choose a reason for hiding this comment

pietern Nov 20, 2024

Choose a reason for hiding this comment

andrewnester left a comment

Choose a reason for hiding this comment

alexott commented Nov 21, 2024

andrewnester commented Nov 21, 2024

andrewnester commented Nov 21, 2024

github-actions bot commented Nov 22, 2024

eng-dev-ecosystem-bot commented Nov 22, 2024

nkvuong commented Nov 22, 2024

[Feature] Add `databricks_app` resource #4099

[Feature] Add `databricks_app` resource #4099

nkvuong commented Oct 12, 2024 •

edited

Loading