Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata file to link to CLI deploy #170

Closed
wants to merge 1 commit into from
Closed

Add metadata file to link to CLI deploy #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ https://github.com/databricks/mlops-stacks/assets/87999496/0d220d55-465e-4a69-bd

### Prerequisites
- Python 3.8+
- [Databricks CLI](https://docs.databricks.com/en/dev-tools/cli/databricks-cli.html) >= v0.221.0
- [Databricks CLI](https://docs.databricks.com/en/dev-tools/cli/databricks-cli.html) >= v0.227.1

[Databricks CLI](https://docs.databricks.com/en/dev-tools/cli/databricks-cli.html) contains [Databricks asset bundle templates](https://docs.databricks.com/en/dev-tools/bundles/templates.html) for the purpose of project creation.

Expand Down
2 changes: 1 addition & 1 deletion databricks_template_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"welcome_message": "Welcome to MLOps Stacks. For detailed information on project generation, see the README at https://github.com/databricks/mlops-stacks/blob/main/README.md.",
"min_databricks_cli_version": "v0.221.0",
"min_databricks_cli_version": "v0.227.1",
"properties": {
"input_setup_cicd_and_project": {
"order": 1,
Expand Down
2 changes: 1 addition & 1 deletion library/template_variables.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
{{- end }}

{{ define `cli_version` -}}
v0.221.0
v0.227.1
{{- end }}

{{ define `stacks_version` -}}
Expand Down
11 changes: 11 additions & 0 deletions template/{{.input_root_dir}}/.stacks_metadata.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# DO NOT MODIFY THIS AUTO-GENERATED FILE.
# MODIFYING THIS FILE MAY CAUSE YOUR STACK TO NOT FUNCTION PROPERLY
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really claim this here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is true, in the future we will use this UUID for other things too, so want to make sure no one modifies it

uuid: "{{ uuid }}"
Copy link
Collaborator

@shreyas-goenka shreyas-goenka Sep 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea: We could emit all these details as usage logs during template creation. Then we'll only have to persist:

uuid: <>
source_template: mlops-stacks

We could join on uuid during analysis.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that be possible since bundle init doesn't require authentication right? Would we use the unauthenticated usage log endpoint for this? Also, we'd need to still attach UUID to that initial log during template creation

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does mlops-stacks use the {{workspace_host}} helper? If so auth is required. It might be required even if you don't use the helper. I'd have to check.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use the helper (we ask the user to specifically input workspaces that they plan to deploy to)

input_setup_cicd_and_project: "{{ .input_setup_cicd_and_project }}"
input_cloud: "{{ .input_cloud }}"
input_cicd_platform: "{{ .input_cicd_platform }}"
input_include_models_in_unity_catalog: "{{ .input_include_models_in_unity_catalog }}"
input_include_feature_store: "{{ .input_include_feature_store }}"
input_include_mlflow_recipes: "{{ .input_include_mlflow_recipes }}"
input_cli_version: "{{template `cli_version` .}}"
stacks_version: "{{template `stacks_version` .}}"
2 changes: 1 addition & 1 deletion tests/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# Usage in the wild uses the "curl | sh" approach and we need that to continue working.
set -e

VERSION="0.221.0"
VERSION="0.227.1"
FILE="databricks_cli_$VERSION"

# Include operating system in file name.
Expand Down
Loading