Project import generated by Copybara. - #12
Open
viveksjain wants to merge 1 commit into
Open
viveksjain wants to merge 1 commit into
viveksjain wants to merge 1 commit into
Conversation
- Laying the groundwork for Rust client libraries - basic Rust build tooling - More detailed client metrics - The Java Target wrapper adds a getName() accessor - Various internal changes FolderOrigin-RevId: /home/vivek.jain/universe Source commit: 4e86a4413e718
prajmoharana
approved these changes
Sep 21, 2026
prajmoharana
left a comment
prajmoharana
left a comment
Collaborator
There was a problem hiding this comment.
LGTM but consider comments for future releases.
Collaborator
There was a problem hiding this comment.
This file mentions team names in eng-team-info.json which is leaking internal DB information. Should we look to create a different comment for OSS or a no-op wrapper?
Collaborator
There was a problem hiding this comment.
Or honestly we can just remove the reference to this file.
| assert(!sliceletConfNoFakeFlag.isFeatureRolloutFlagEnabled("feature-on", target)) | ||
| assert(errorCount.totalChange() == 1) | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
We need to look into how we add src code removal because another spurious line change.
Either need to look into improving transformation pipeline or add explicit documentation on how to use removal comments.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FolderOrigin-RevId: /home/vivek.jain/universe
Source commit: 4e86a4413e718