Skip to content

Enhance SEA HTTP Client #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 352 commits into
base: sea-migration
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
352 commits
Select commit Hold shift + click to select a range
cbace3f
Revert "Merge branch 'exec-models-sea' into exec-phase-sea"
varun-edachali-dbx Jun 12, 2025
c075b07
change logging level
varun-edachali-dbx Jun 12, 2025
c62f76d
remove un-necessary changes
varun-edachali-dbx Jun 12, 2025
199402e
remove excess changes
varun-edachali-dbx Jun 12, 2025
8ac574b
remove excess changes
varun-edachali-dbx Jun 12, 2025
398ca70
Merge branch 'sea-migration' into exec-phase-sea
varun-edachali-dbx Jun 12, 2025
b1acc5b
remove _get_schema_bytes (for now)
varun-edachali-dbx Jun 12, 2025
ef2a7ee
redundant comments
varun-edachali-dbx Jun 12, 2025
699942d
Merge branch 'sea-migration' into exec-phase-sea
varun-edachali-dbx Jun 12, 2025
af8f74e
remove fetch phase methods
varun-edachali-dbx Jun 12, 2025
5540c5c
reduce code repetititon + introduce gaps after multi line pydocs
varun-edachali-dbx Jun 12, 2025
efe3881
remove unused imports
varun-edachali-dbx Jun 12, 2025
36ab59b
move description extraction to helper func
varun-edachali-dbx Jun 12, 2025
1d57c99
formatting (black)
varun-edachali-dbx Jun 12, 2025
df6dac2
add more unit tests
varun-edachali-dbx Jun 12, 2025
ad0e527
streamline unit tests
varun-edachali-dbx Jun 12, 2025
ed446a0
test getting the list of allowed configurations
varun-edachali-dbx Jun 12, 2025
38e4b5c
reduce diff
varun-edachali-dbx Jun 12, 2025
94879c0
reduce diff
varun-edachali-dbx Jun 12, 2025
1809956
house constants in enums for readability and immutability
varun-edachali-dbx Jun 13, 2025
da5260c
add note on hybrid disposition
varun-edachali-dbx Jun 13, 2025
6ec265f
[squashed from cloudfetch-sea] introduce external links + arrow funct…
varun-edachali-dbx Jun 16, 2025
b2ad5e6
reduce responsibility of Queue
varun-edachali-dbx Jun 16, 2025
66d0df6
reduce repetition in arrow tablee creation
varun-edachali-dbx Jun 16, 2025
eb7ec80
reduce redundant code in CloudFetchQueue
varun-edachali-dbx Jun 16, 2025
a3a8a4a
move chunk link progression to separate func
varun-edachali-dbx Jun 16, 2025
ea79bc8
remove redundant log
varun-edachali-dbx Jun 16, 2025
5b49405
improve logging
varun-edachali-dbx Jun 16, 2025
015fb76
remove reliance on schema_bytes in SEA
varun-edachali-dbx Jun 16, 2025
0385ffb
remove redundant note on arrow_schema_bytes
varun-edachali-dbx Jun 16, 2025
5380c7a
use more fetch methods
varun-edachali-dbx Jun 16, 2025
27b781f
remove redundant schema_bytes from parent constructor
varun-edachali-dbx Jun 16, 2025
238dc0a
only call get_chunk_link with non null chunk index
varun-edachali-dbx Jun 16, 2025
b3bb07e
align SeaResultSet structure with ThriftResultSet
varun-edachali-dbx Jun 16, 2025
13e6346
remvoe _fill_result_buffer from SeaResultSet
varun-edachali-dbx Jun 16, 2025
f90b4d4
reduce code repetition
varun-edachali-dbx Jun 16, 2025
23963fc
align SeaResultSet with ext-links-sea
varun-edachali-dbx Jun 16, 2025
dd43715
remove redundant methods
varun-edachali-dbx Jun 16, 2025
34a7f66
update unit tests
varun-edachali-dbx Jun 16, 2025
715cc13
remove accidental venv changes
varun-edachali-dbx Jun 16, 2025
fb53dd9
pre-fetch next chunk link on processing current
varun-edachali-dbx Jun 17, 2025
d893877
reduce nesting
varun-edachali-dbx Jun 17, 2025
a165f1c
line break after multi line pydoc
varun-edachali-dbx Jun 17, 2025
d68e4ea
re-introduce schema_bytes for better abstraction (likely temporary)
varun-edachali-dbx Jun 17, 2025
be17812
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx Jun 17, 2025
a0705bc
add fetchmany_arrow and fetchall_arrow
varun-edachali-dbx Jun 17, 2025
1b90c4a
Merge branch 'metadata-sea' into fetch-json-inline
varun-edachali-dbx Jun 17, 2025
f7c11b9
remove accidental changes in sea backend tests
varun-edachali-dbx Jun 17, 2025
349c021
Merge branch 'exec-phase-sea' into metadata-sea
varun-edachali-dbx Jun 17, 2025
6229848
remove irrelevant changes
varun-edachali-dbx Jun 17, 2025
fd52356
remove un-necessary test changes
varun-edachali-dbx Jun 17, 2025
64e58b0
remove un-necessary changes in thrift backend tests
varun-edachali-dbx Jun 17, 2025
2903473
remove unimplemented methods test
varun-edachali-dbx Jun 17, 2025
b300709
Merge branch 'metadata-sea' into fetch-json-inline
varun-edachali-dbx Jun 17, 2025
021ff4c
remove unimplemented method tests
varun-edachali-dbx Jun 17, 2025
adecd53
modify example scripts to include fetch calls
varun-edachali-dbx Jun 17, 2025
d33e5fd
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx Jun 17, 2025
e3cef5c
add GetChunksResponse
varun-edachali-dbx Jun 17, 2025
ac50669
remove changes to sea test
varun-edachali-dbx Jun 17, 2025
03cdc4f
re-introduce accidentally removed description extraction method
varun-edachali-dbx Jun 17, 2025
e1842d8
fix type errors (ssl_options, CHUNK_PATH_WITH_ID..., etc.)
varun-edachali-dbx Jun 17, 2025
89a46af
access ssl_options through connection
varun-edachali-dbx Jun 17, 2025
1d0b28b
DEBUG level
varun-edachali-dbx Jun 17, 2025
c8820d4
remove explicit multi chunk test
varun-edachali-dbx Jun 17, 2025
fe47787
move cloud fetch queues back into utils.py
varun-edachali-dbx Jun 17, 2025
74f59b7
remove excess docstrings
varun-edachali-dbx Jun 17, 2025
4b456b2
move ThriftCloudFetchQueue above SeaCloudFetchQueue
varun-edachali-dbx Jun 17, 2025
bfc1f01
fix sea connector tests
varun-edachali-dbx Jun 17, 2025
a4447a1
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx Jun 17, 2025
4883aff
correct patch module path in cloud fetch queue tests
varun-edachali-dbx Jun 17, 2025
0a2cdfd
remove unimplemented methods test
varun-edachali-dbx Jun 17, 2025
cd3378c
correct add_link docstring
varun-edachali-dbx Jun 17, 2025
90bb09c
Merge branch 'sea-migration' into exec-phase-sea
varun-edachali-dbx Jun 17, 2025
cd22389
remove invalid import
varun-edachali-dbx Jun 17, 2025
82e0f8b
Merge branch 'sea-migration' into exec-phase-sea
varun-edachali-dbx Jun 17, 2025
e64b81b
Merge branch 'exec-phase-sea' into metadata-sea
varun-edachali-dbx Jun 17, 2025
27564ca
Merge branch 'metadata-sea' into fetch-json-inline
varun-edachali-dbx Jun 17, 2025
bc467d1
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx Jun 17, 2025
5ab9bbe
better align queries with JDBC impl
varun-edachali-dbx Jun 18, 2025
1ab6e87
line breaks after multi-line PRs
varun-edachali-dbx Jun 18, 2025
f469c24
remove unused imports
varun-edachali-dbx Jun 18, 2025
68ec65f
fix: introduce ExecuteResponse import
varun-edachali-dbx Jun 18, 2025
ffd478e
Merge branch 'sea-migration' into metadata-sea
varun-edachali-dbx Jun 18, 2025
f6d873d
remove unimplemented metadata methods test, un-necessary imports
varun-edachali-dbx Jun 18, 2025
28675f5
introduce unit tests for metadata methods
varun-edachali-dbx Jun 18, 2025
3578659
remove verbosity in ResultSetFilter docstring
varun-edachali-dbx Jun 20, 2025
8713023
remove un-necessary info in ResultSetFilter docstring
varun-edachali-dbx Jun 20, 2025
22dc252
remove explicit type checking, string literals around forward annotat…
varun-edachali-dbx Jun 20, 2025
390f592
house SQL commands in constants
varun-edachali-dbx Jun 20, 2025
dd7dc6a
convert complex types to string if not _use_arrow_native_complex_types
varun-edachali-dbx Jun 23, 2025
28308fe
Merge branch 'metadata-sea' into fetch-json-inline
varun-edachali-dbx Jun 23, 2025
2712d1c
introduce unit tests for altered functionality
varun-edachali-dbx Jun 23, 2025
dabba55
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx Jun 23, 2025
48ad7b3
Revert "Merge branch 'fetch-json-inline' into ext-links-sea"
varun-edachali-dbx Jun 23, 2025
a1f9b9c
reduce verbosity of ResultSetFilter docstring
varun-edachali-dbx Jun 23, 2025
984e8ee
remove unused imports
varun-edachali-dbx Jun 23, 2025
3a999c0
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx Jun 23, 2025
c313c2b
Revert "Merge branch 'fetch-json-inline' into ext-links-sea"
varun-edachali-dbx Jun 23, 2025
3bc615e
Revert "reduce verbosity of ResultSetFilter docstring"
varun-edachali-dbx Jun 23, 2025
b6e1a10
Reapply "Merge branch 'fetch-json-inline' into ext-links-sea"
varun-edachali-dbx Jun 23, 2025
2df3d39
Revert "Merge branch 'fetch-json-inline' into ext-links-sea"
varun-edachali-dbx Jun 23, 2025
5e75fb5
remove un-necessary filters changes
varun-edachali-dbx Jun 23, 2025
20822e4
remove un-necessary backend changes
varun-edachali-dbx Jun 23, 2025
802d045
remove constants changes
varun-edachali-dbx Jun 23, 2025
f3f795a
remove changes in filters tests
varun-edachali-dbx Jun 23, 2025
f6c5950
remove unit test backend and JSON queue changes
varun-edachali-dbx Jun 23, 2025
d210ccd
remove changes in sea result set testing
varun-edachali-dbx Jun 23, 2025
22a953e
Revert "remove changes in sea result set testing"
varun-edachali-dbx Jun 23, 2025
3aed144
Revert "remove unit test backend and JSON queue changes"
varun-edachali-dbx Jun 23, 2025
0fe4da4
Revert "remove changes in filters tests"
varun-edachali-dbx Jun 23, 2025
0e3c0a1
Revert "remove constants changes"
varun-edachali-dbx Jun 23, 2025
93edb93
Revert "remove un-necessary backend changes"
varun-edachali-dbx Jun 23, 2025
871a44f
Revert "remove un-necessary filters changes"
varun-edachali-dbx Jun 23, 2025
0ce144d
remove unused imports
varun-edachali-dbx Jun 23, 2025
08ca60d
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx Jun 23, 2025
8c5cc77
working version
varun-edachali-dbx Jun 23, 2025
7f5c715
adopy _wait_until_command_done
varun-edachali-dbx Jun 23, 2025
9ef5fad
introduce metadata commands
varun-edachali-dbx Jun 23, 2025
44183db
use new backend structure
varun-edachali-dbx Jun 23, 2025
d59b351
constrain backend diff
varun-edachali-dbx Jun 23, 2025
1edc80a
remove changes to filters
varun-edachali-dbx Jun 23, 2025
f82658a
make _parse methods in models internal
varun-edachali-dbx Jun 23, 2025
54eb0a4
reduce changes in unit tests
varun-edachali-dbx Jun 23, 2025
50cc1e2
run small queries with SEA during integration tests
varun-edachali-dbx Jun 24, 2025
242307a
run some tests for sea
varun-edachali-dbx Jun 24, 2025
8a138e8
allow empty schema bytes for alignment with SEA
varun-edachali-dbx Jun 25, 2025
82f9d6b
pass is_vl_op to Sea backend ExecuteResponse
varun-edachali-dbx Jun 25, 2025
35f1ef0
remove catalog requirement in get_tables
varun-edachali-dbx Jun 26, 2025
a515d26
move filters.py to SEA utils
varun-edachali-dbx Jun 26, 2025
59b1330
ensure SeaResultSet
varun-edachali-dbx Jun 26, 2025
293e356
Merge branch 'sea-migration' into metadata-sea
varun-edachali-dbx Jun 26, 2025
dd40beb
prevent circular imports
varun-edachali-dbx Jun 26, 2025
14057ac
remove unused imports
varun-edachali-dbx Jun 26, 2025
a4d5bdb
remove cast, throw error if not SeaResultSet
varun-edachali-dbx Jun 26, 2025
156421a
Merge branch 'metadata-sea' into fetch-json-inline
varun-edachali-dbx Jun 26, 2025
eb1a9b4
pass param as TSparkParameterValue
varun-edachali-dbx Jun 26, 2025
9000666
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx Jun 26, 2025
a3ca7c7
remove failing test (temp)
varun-edachali-dbx Jun 26, 2025
2c22010
remove SeaResultSet type assertion
varun-edachali-dbx Jun 26, 2025
c09508e
change errors to align with spec, instead of arbitrary ValueError
varun-edachali-dbx Jun 26, 2025
e9b1314
make SEA backend methods return SeaResultSet
varun-edachali-dbx Jun 26, 2025
8ede414
use spec-aligned Exceptions in SEA backend
varun-edachali-dbx Jun 26, 2025
09a1b11
remove defensive row type check
varun-edachali-dbx Jun 26, 2025
5e01e7b
Merge branch 'metadata-sea' into fetch-json-inline
varun-edachali-dbx Jun 26, 2025
3becefe
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx Jun 26, 2025
a026d31
raise ProgrammingError for invalid id
varun-edachali-dbx Jun 26, 2025
4446a9e
make is_volume_operation strict bool
varun-edachali-dbx Jun 26, 2025
138359d
remove complex types code
varun-edachali-dbx Jun 26, 2025
b99d0c4
Revert "remove complex types code"
varun-edachali-dbx Jun 26, 2025
21c389d
introduce type conversion for primitive types for JSON + INLINE
varun-edachali-dbx Jun 27, 2025
734321a
Merge branch 'sea-migration' into fetch-json-inline
varun-edachali-dbx Jun 27, 2025
9f0f969
remove SEA running on metadata queries (known failures
varun-edachali-dbx Jun 27, 2025
04a1936
remove un-necessary docstrings
varun-edachali-dbx Jun 27, 2025
11bc165
preliminary (robust) SEA HTTP Client
varun-edachali-dbx Jun 27, 2025
d389316
prevent catching of MaxRetryError and HttpError in client
varun-edachali-dbx Jun 27, 2025
cc48caf
formatting (black)
varun-edachali-dbx Jun 27, 2025
6a1274f
fix type annotations
varun-edachali-dbx Jun 27, 2025
278b8cd
align expected types with databricks sdk
varun-edachali-dbx Jun 27, 2025
91b7f7f
link rest api reference to validate types
varun-edachali-dbx Jun 27, 2025
7a5ae13
remove test_catalogs_returns_arrow_table test
varun-edachali-dbx Jun 27, 2025
f1776f3
fix fetchall_arrow and fetchmany_arrow
varun-edachali-dbx Jun 27, 2025
6143331
remove thrift aligned test_cancel_during_execute from SEA tests
varun-edachali-dbx Jun 27, 2025
8949d0c
Merge branch 'sea-migration' into fetch-json-inline
varun-edachali-dbx Jun 27, 2025
5eaded4
remove un-necessary changes in example scripts
varun-edachali-dbx Jun 27, 2025
eeed9a1
remove un-necessary chagnes in example scripts
varun-edachali-dbx Jun 27, 2025
f233886
_convert_json_table -> _create_json_table
varun-edachali-dbx Jun 27, 2025
68ac437
remove accidentally removed test
varun-edachali-dbx Jun 27, 2025
7fd0845
remove new unit tests (to be re-added based on new arch)
varun-edachali-dbx Jun 27, 2025
ea7ff73
remove changes in sea_result_set functionality (to be re-added)
varun-edachali-dbx Jun 27, 2025
563da71
introduce more integration tests
varun-edachali-dbx Jun 27, 2025
a018273
remove SEA tests in parameterized queries
varun-edachali-dbx Jun 27, 2025
c0e98f4
remove partial parameter fix changes
varun-edachali-dbx Jun 27, 2025
7343035
remove un-necessary timestamp tests
varun-edachali-dbx Jun 27, 2025
ec500b6
slightly stronger typing of _convert_json_types
varun-edachali-dbx Jun 27, 2025
0b3e91d
stronger typing of json utility func s
varun-edachali-dbx Jun 27, 2025
7664e44
stronger typing of fetch*_json
varun-edachali-dbx Jun 27, 2025
db7b8e5
remove unused helper methods in SqlType
varun-edachali-dbx Jun 27, 2025
f75f2b5
line breaks after multi line pydocs, remove excess logs
varun-edachali-dbx Jun 27, 2025
e2d4ef5
line breaks after multi line pydocs, reduce diff of redundant changes
varun-edachali-dbx Jun 27, 2025
21e3078
reduce diff of redundant changes
varun-edachali-dbx Jun 27, 2025
bb015e6
mandate ResultData in SeaResultSet constructor
varun-edachali-dbx Jun 27, 2025
3944e39
Merge branch 'fetch-json-inline' into ext-links-sea
varun-edachali-dbx Jun 27, 2025
b3273c7
remove complex type conversion
varun-edachali-dbx Jun 27, 2025
38c2b88
correct fetch*_arrow
varun-edachali-dbx Jun 27, 2025
ebc1915
Merge branch 'ext-links-sea' into sea-http-client
varun-edachali-dbx Jun 27, 2025
4651cd6
pass test_retry_exponential_backoff
varun-edachali-dbx Jun 30, 2025
d67eb7b
prevent parsing empty response data (get test_retry_abort_non_recover…
varun-edachali-dbx Jun 30, 2025
2caf38d
more defensive parsing, allow more method types in urllib3
varun-edachali-dbx Jun 30, 2025
3e55ddd
allow Any values in session_conf, cast to String as done in Thrift ba…
varun-edachali-dbx Jun 30, 2025
4afff39
account for max_redirects in SEA backend
varun-edachali-dbx Jun 30, 2025
01d49cd
return empty JsonQueue if no data
varun-edachali-dbx Jul 1, 2025
3d8aa7f
do not preload content?
varun-edachali-dbx Jul 2, 2025
b77acbe
Merge branch 'sea-migration' into ext-links-sea
varun-edachali-dbx Jul 3, 2025
fa2359d
recover old sea tests
varun-edachali-dbx Jul 3, 2025
c07f709
move queue and result set into SEA specific dir
varun-edachali-dbx Jul 3, 2025
9e4ef2e
pass ssl_options into CloudFetchQueue
varun-edachali-dbx Jul 3, 2025
b00c06c
reduce diff
varun-edachali-dbx Jul 3, 2025
10f55f0
remove redundant conversion.py
varun-edachali-dbx Jul 3, 2025
cd119e9
fix type issues
varun-edachali-dbx Jul 3, 2025
d79638b
ValueError not ProgrammingError
varun-edachali-dbx Jul 3, 2025
f84578a
reduce diff
varun-edachali-dbx Jul 3, 2025
c621c0c
introduce SEA cloudfetch e2e tests
varun-edachali-dbx Jul 3, 2025
7958cd9
allow empty cloudfetch result
varun-edachali-dbx Jul 3, 2025
e2d17ff
add unit tests for CloudFetchQueue and SeaResultSet
varun-edachali-dbx Jul 3, 2025
d348b35
skip pyarrow dependent tests
varun-edachali-dbx Jul 3, 2025
811205e
Merge branch 'sea-migration' into ext-links-sea
varun-edachali-dbx Jul 3, 2025
4bd290e
simplify download process: no pre-fetching
varun-edachali-dbx Jul 4, 2025
dfbbf79
correct class name in logs
varun-edachali-dbx Jul 4, 2025
b12a8b0
Merge branch 'ext-links-sea' into sea-http-client
varun-edachali-dbx Jul 7, 2025
ed4d7ab
Merge branch 'sea-migration' into ext-links-sea
varun-edachali-dbx Jul 7, 2025
51aa9be
add sea tag on large queries
varun-edachali-dbx Jul 7, 2025
a5e9cdf
align with old impl
varun-edachali-dbx Jul 7, 2025
be16634
align next_n_rows with prev imple
varun-edachali-dbx Jul 7, 2025
6ec8656
align remaining_rows with prev impl
varun-edachali-dbx Jul 7, 2025
7ea7b75
remove un-necessary Optional params
varun-edachali-dbx Jul 7, 2025
64be07b
remove un-necessary changes in thrift field if tests
varun-edachali-dbx Jul 7, 2025
165644c
remove unused imports
varun-edachali-dbx Jul 7, 2025
3172ab8
Merge branch 'ext-links-sea' into sea-http-client
varun-edachali-dbx Jul 7, 2025
461e762
simplify error handling
varun-edachali-dbx Jul 7, 2025
fd1e6cf
stop mypy complaints
varun-edachali-dbx Jul 8, 2025
abef941
run large queries
varun-edachali-dbx Jul 8, 2025
15378de
run retry tests
varun-edachali-dbx Jul 8, 2025
83de7d9
Merge branch 'ext-links-sea' into sea-http-client
varun-edachali-dbx Jul 8, 2025
fce324b
move link fetching immediately before table creation so link expiry i…
varun-edachali-dbx Jul 11, 2025
39469fa
Merge branch 'sea-migration' into ext-links-sea
varun-edachali-dbx Jul 11, 2025
b2d1579
formatting (black)
varun-edachali-dbx Jul 11, 2025
077a71c
fix types
varun-edachali-dbx Jul 11, 2025
7985639
fix param type in unit tests
varun-edachali-dbx Jul 11, 2025
dfc32b4
Merge branch 'sea-migration' into ext-links-sea
varun-edachali-dbx Jul 14, 2025
0a0643b
correct param extraction
varun-edachali-dbx Jul 14, 2025
f7fd1d9
remove common constructor for databricks client abc
varun-edachali-dbx Jul 14, 2025
510b0a3
make SEA Http Client instance a private member
varun-edachali-dbx Jul 14, 2025
dd2864b
make GetChunksResponse model more robust
varun-edachali-dbx Jul 14, 2025
c32b281
add link to doc of GetChunk response model
varun-edachali-dbx Jul 14, 2025
0b1eba5
pass result_data instead of "initial links" into SeaCloudFetchQueue
varun-edachali-dbx Jul 14, 2025
777f7c1
move download_manager init into parent CloudFetchQueue
varun-edachali-dbx Jul 14, 2025
130b0d3
raise ServerOperationError for no 0th chunk
varun-edachali-dbx Jul 14, 2025
1920375
unused iports
varun-edachali-dbx Jul 14, 2025
d882c6e
Merge branch 'sea-migration' into ext-links-sea
varun-edachali-dbx Jul 15, 2025
7fb59e4
Merge branch 'ext-links-sea' into sea-http-client
varun-edachali-dbx Jul 15, 2025
25596e7
simplify HTTP client using requests.session
varun-edachali-dbx Jul 15, 2025
2124fe0
explicitly close response object
varun-edachali-dbx Jul 15, 2025
404aadf
formatting (black)
varun-edachali-dbx Jul 15, 2025
01c9b95
remove excess changes
varun-edachali-dbx Jul 15, 2025
5a43686
return None in case of empty respose
varun-edachali-dbx Jul 15, 2025
28c6bb1
ensure table is empty on no initial link s
varun-edachali-dbx Jul 15, 2025
41f1130
Merge branch 'ext-links-sea' into sea-http-client
varun-edachali-dbx Jul 15, 2025
97707f5
Merge branch 'sea-migration' into sea-http-client
varun-edachali-dbx Jul 16, 2025
36daee6
Revert "explicitly close response object"
varun-edachali-dbx Jul 16, 2025
b3fb5fa
Revert "simplify HTTP client using requests.session"
varun-edachali-dbx Jul 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/databricks/sql/auth/retry.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import typing
from importlib.metadata import version
from enum import Enum
from typing import List, Optional, Tuple, Union
from typing import Any, List, Optional, Tuple, Union

import urllib3

Expand Down Expand Up @@ -123,15 +123,15 @@ def __init__(
_total: int = urllib3_kwargs.pop("total")
_attempts_remaining = _total

_urllib_kwargs_we_care_about = dict(
_urllib_kwargs_we_care_about: dict[str, Any] = dict(
total=_attempts_remaining,
respect_retry_after_header=True,
backoff_factor=self.delay_min,
allowed_methods=["POST"],
status_forcelist=[429, 503, *self.force_dangerous_codes],
)

urllib3_kwargs.update(**_urllib_kwargs_we_care_about)
_urllib_kwargs_we_care_about.update(**urllib3_kwargs)
urllib3_kwargs = _urllib_kwargs_we_care_about

super().__init__(
**urllib3_kwargs,
Expand Down
Loading
Loading