Add debug authorization header flag #754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
suggested changes
Jan 3, 2024
httpclient/api_client.go
Outdated
| @@ -257,8 +258,8 @@ func (c *ApiClient) recordRequestLog( | |||
| RequestBody: requestBody, | |||
| ResponseBody: responseBody, | |||
| DebugHeaders: c.config.DebugHeaders, | |||
| DebugAuthorizationHeader: c.config.DebugAuthorizationHeader, | |||
There was a problem hiding this comment.
you're missing the X-Databricks-Azure-SP-Management-Token and X-Databricks-GCP-SA-Access-Token headers in https://github.com/databricks/databricks-sdk-go/blob/main/logger/httplog/round_trip_stringer.go#L33-L35
There was a problem hiding this comment.
I think you reviewed a stale version but I added this in the last commit
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
==========================================
+ Coverage 17.78% 17.79% +0.01%
==========================================
Files 106 106
Lines 14199 14201 +2
==========================================
+ Hits 2525 2527 +2
Misses 11463 11463
Partials 211 211 ☔ View full report in Codecov by Sentry. |
tanmay-db
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
DebugHeaders by default prints all headers, including the sensitive Authorization header. To allow users to print debug logs with headers but without including this sensitive header, we introduce a new flag, DebugAuthorizationHeader, which is disabled by default for users. This way, enabling debug headers does not automatically leak the token used to authenticate to our REST API.
Tests
make testpassingmake fmtapplied