bundle: report deployment history in deploy telemetry - #6779
Draft
shreyas-goenka wants to merge 1 commit into
Draft
shreyas-goenka wants to merge 1 commit into
shreyas-goenka wants to merge 1 commit into
Conversation
Collaborator
Integration test reportCommit: fbe852b
23 interesting tests: 23 FAIL
Top 15 slowest tests (at least 2 minutes):
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
deployment_history_enabledto bundle deploy telemetry using the existingIsDirectWithHistorypredicate. Emit both true and false and update the affected telemetry golden files.Based on #5365, which supplies the engine predicate.
Testing
go test ./bundle ./bundle/config/engine ./bundle/phasesand all seven affected telemetry acceptance cases pass.