Extract IsSPOG and ResolveConfigType into libs/auth#4939
Open
mihaimitrea-db wants to merge 2 commits intomihaimitrea-db/fix-profiles-spog-classificationfrom
Open
Extract IsSPOG and ResolveConfigType into libs/auth#4939mihaimitrea-db wants to merge 2 commits intomihaimitrea-db/fix-profiles-spog-classificationfrom
mihaimitrea-db wants to merge 2 commits intomihaimitrea-db/fix-profiles-spog-classificationfrom
Conversation
Deduplicate SPOG detection logic between profiles.go and ToOAuthArgument. IsSPOG checks DiscoveryURL and IsUnifiedHost, ResolveConfigType wraps ConfigType with SPOG-aware overrides.
Approval status: pending
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsSPOG(cfg, accountID)predicate inlibs/auth/config_type.go, replacing inline checks in bothprofiles.goandToOAuthArgument.ResolveConfigType(cfg)that wrapsConfigType()with SPOG-aware overrides, used byprofiles.go.ToOAuthArgumentnow callsIsSPOGinstead of duplicating theDiscoveryURL+IsUnifiedHostchecks inline.Follow-up to #4929 as suggested in review comment #2 (logic duplication).
Test plan
TestResolveConfigType— 9-case table-driven unit test inlibs/auth/config_type_test.go.TestProfileLoad*andTestToOAuthArgument*tests pass.go test ./libs/auth/ ./cmd/auth/passes.