Map postgres autoscaling fields to float64 in bundle TF schema #4398
+91
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes Added allowlist to Terraform schema generator to emit `float64` for postgres autoscaling fields. All other number fields remain `int`. Note: Other fields (cluster_cores, spot_bid_max_price, etc.) also need float64 but are deferred to handle postgres resources first. ## Why Postgres autoscaling supports fractional CU values (e.g., 0.5). The previous implementation mapped all `cty.Number` to `int`, truncating fractional values and mismatching databricks-sdk-go types. ## Tests Verified postgres autoscaling fields are `float64` and other number fields remain `int`. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
pietern
requested review from
andrewnester,
anton-107,
denik and
shreyas-goenka
as code owners
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 617baf0
22 interesting tests: 9 KNOWN, 5 SKIP, 5 flaky, 3 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
shreyas-goenka
approved these changes
Jan 30, 2026
Collaborator
|
Commit: 509ebe9
28 interesting tests: 10 flaky, 9 KNOWN, 5 SKIP, 4 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added allowlist to Terraform schema generator to emit
float64for postgres autoscaling fields. All other number fields remainint.Note: Other fields (cluster_cores, spot_bid_max_price, etc.) also need float64 but are deferred to handle postgres resources first. These are not implemented yet so changing them doesn't impact anything.
Why
Postgres autoscaling supports fractional CU values (e.g., 0.5). The previous implementation mapped all
cty.Numbertoint, truncating fractional values and mismatching databricks-sdk-go types.Tests
Verified postgres autoscaling fields are
float64and other number fields remainint.