Add experimental-jobs-as-code template #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanterov
requested review from
pietern,
andrewnester,
shreyas-goenka and
denik
as code owners
kanterov
force-pushed
the
kanterov/experimental-jobs-as-code-template
branch
from
29fff27 to
5fa0e99
Compare
pietern
approved these changes
Jan 20, 2025
| @@ -0,0 +1 @@ | |||
| rm -fr my_jobs_as_code | |||
There was a problem hiding this comment.
No effect, this file can be removed.
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
denik
reviewed
Jan 23, 2025
| // depends on uv version | ||
| "uv.lock", | ||
| } | ||
|
|
There was a problem hiding this comment.
The approach we use is to clean up unnecessary files at the end of script.
In general, it is interesting to know which test case create which files.
There was a problem hiding this comment.
Please keep these test-scoped: #2215
denik
added a commit
that referenced
this pull request
Jan 23, 2025
denik
added a commit
that referenced
this pull request
Jan 23, 2025
Revert changes to acceptance_test.go added in #2177 and add test-specific fix.
andrewnester
added a commit
that referenced
this pull request
Jan 23, 2025
CLI: * Added text output templates for apps list and list-deployments ([#2175](#2175)). * Fix duplicate "apps" entry in help output ([#2191](#2191)). Bundles: * Allow yaml-anchors in schema ([#2200](#2200)). * Show an error when non-yaml files used in include section ([#2201](#2201)). * Set WorktreeRoot to sync root outside git repo ([#2197](#2197)). * fix: Detailed message for using source-linked deployment with file_path specified ([#2119](#2119)). * Allow using variables in enum fields ([#2199](#2199)). * Add experimental-jobs-as-code template ([#2177](#2177)). * Reading variables from file ([#2171](#2171)). * Fixed an apps message order and added output test ([#2174](#2174)). * Default to forward slash-separated paths for path translation ([#2145](#2145)). * Include a materialized copy of built-in templates ([#2146](#2146)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
CLI: * Added text output templates for apps list and list-deployments ([#2175](#2175)). * Fix duplicate "apps" entry in help output ([#2191](#2191)). Bundles: * Allow yaml-anchors in schema ([#2200](#2200)). * Show an error when non-yaml files used in include section ([#2201](#2201)). * Set WorktreeRoot to sync root outside git repo ([#2197](#2197)). * fix: Detailed message for using source-linked deployment with file_path specified ([#2119](#2119)). * Allow using variables in enum fields ([#2199](#2199)). * Add experimental-jobs-as-code template ([#2177](#2177)). * Reading variables from file ([#2171](#2171)). * Fixed an apps message order and added output test ([#2174](#2174)). * Default to forward slash-separated paths for path translation ([#2145](#2145)). * Include a materialized copy of built-in templates ([#2146](#2146)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add experimental-jobs-as-code template allowing defining jobs using Python instead of YAML through the
databricks-bundlesPyPI package.Tests
Manually and acceptance tests.