Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exec(test): Do not clear PATH; this breaks coverage on Windows #2150

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

denik
Copy link
Contributor

@denik denik commented Jan 15, 2025

Changes

When setting up PATH in tests, put desired entry first but keep the rest as well. Otherwise it fails on Windows

D:/a/cli/cli/libs/exec/exec_test.go:108
Error: Received unexpected error:
exit status 0xc0000135

Explanation from Claude:

The error code 0xc0000135 is a Windows error indicating "Unable to locate DLL"
When code coverage is enabled, Go instruments the binary with coverage tracking code, which requires additional DLL dependencies on Windows.

Tests

Separate draft PR with coverage enabled on CI: #2141

@denik
Copy link
Contributor Author

denik commented Jan 15, 2025

Integration tests failures are unrelated.

@denik denik disabled auto-merge January 15, 2025 11:05
@denik denik merged commit 40e96b5 into main Jan 15, 2025
8 of 9 checks passed
@denik denik deleted the denik/fix-exec-tests branch January 15, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants