fix: patch sdk-experimental for local-proxy HTTP host#348
Open
fix: patch sdk-experimental for local-proxy HTTP host#348
Conversation
Workaround for @databricks/sdk-experimental upgrading http:// URLs to https://, which breaks the local API proxy at http://127.0.0.1:8004. - Bump @databricks/sdk-experimental from 0.14.2 to 0.15.0 - Add patch-package as a devDependency - Run patch-package in postinstall before typegen - Add patch for dist/config/Config.js (preserve scheme + port) and dist/api-client.js (use http.Agent for http:// hosts) Backported from universe PR #1876469. This will be unnecessary once databricks/databricks-sdk-js#392 is released and AppKit picks it up. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@databricks/sdk-experimentalfrom0.14.2to0.15.0patch-packageas a devDependency and wired it intopostinstallpatches/@databricks+sdk-experimental+0.15.0.patch— patchesdist/config/Config.jsto preserve scheme + port instead of forcinghttps://, anddist/api-client.jsto usehttp.Agentforhttp://hostsThis is a workaround for the SDK upgrading
http://URLs tohttps://, which breaks the local API proxy athttp://127.0.0.1:8004. Backported from universe PR #1876469. Will be unnecessary once databricks-sdk-js#392 is released.Test plan
npm installin a generated template applies the patch successfullyhttp://local proxyThis pull request and its description were written by Isaac.