Add CI and tests for chat app templates #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sid Murching <[email protected]>
… requirements and flaky on mac Signed-off-by: Sid Murching <[email protected]>
Signed-off-by: Sid Murching <[email protected]>
Signed-off-by: Sid Murching <[email protected]>
jerrylian-db
reviewed
Apr 8, 2025
| @@ -0,0 +1,3 @@ | |||
| pytest>=8.3.2 | |||
Contributor
There was a problem hiding this comment.
Wondering if we can align the environment version with our current app runtime python packages for high fidelity testing https://src.dev.databricks.com/databricks-eng/universe@3cfd7ba4da9b32c458c0812898a482e03b127910/-/blob/apps/runtime/Dockerfile?L25-35
jerrylian-db
requested changes
Apr 8, 2025
Contributor
jerrylian-db
left a comment
jerrylian-db
left a comment
There was a problem hiding this comment.
Thanks so much for doing this! Wondering if we can separate the testing code from the template paths, because all the template code will be deploy on to the DB Apps, e.g. everything under dash-chatbot-app. I would prefer to prevent our testing code from leaking into customer apps.
theof-db
force-pushed
the
main
branch
2 times, most recently
from
3fc8498 to
ea975f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CI to this repo and tests for chatbot app templates